Skip to content

Disable libhdfs3 and osg-qt in linux temporarily#10290

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_osx_baseline_20200303
Mar 3, 2020
Merged

Disable libhdfs3 and osg-qt in linux temporarily#10290
strega-nil merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_osx_baseline_20200303

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 3, 2020

In recent PRs, I found the following regressions in linux:

  • libhdfs3:
CMake Error at /home/work/vcpkg/downloads/tools/cmake-3.14.0-linux/cmake-3.14.0-Linux-x86_64/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find KERBEROS (missing: KERBEROS_LIBRARIES KERBEROS_INCLUDE_DIR)
  • osg-qt: Since ms-angle conflicts with angle and qt-5base, libegl build fails, which leads to this regression.

I will fix them in another PR later.

Related: #10285 #10167 #10253 #10287.

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 3, 2020
@strega-nil strega-nil merged commit 3e57190 into microsoft:master Mar 3, 2020
@strega-nil
Copy link
Contributor

Thanks Jack!

@kreuzerkrieg
Copy link
Contributor

@JackBoosY , any ETA when libhdfs3 is going to make it back?

@JackBoosY
Copy link
Contributor Author

@kreuzerkrieg Less than one week.

@JackBoosY
Copy link
Contributor Author

Since vcpkg does not currently join port Kerberos, we need to remind users to install it with other package managers and fix the issue of finding it.

@kreuzerkrieg
Copy link
Contributor

so, what is the current status of libhdfs3?

@strega-nil
Copy link
Contributor

strega-nil commented Mar 12, 2020

@JackBoosY I don't think kerberos is generally available in package managers (at least, afaict, it's not in the default ubuntu PPAs); I think we have to add krb5 as a port to vcpkg (http://web.mit.edu/kerberos/)

@PhoebeHui
Copy link
Contributor

@kreuzerkrieg, it looks you are the author of the libhdfs3 port in vcpkg, do you know if kerberos required to build libhdfs3, if there is a way to disable it? it built failed on linux when configure the project. Could you give us some suggestion?

BTW, I'm curious about PR #10021, why the ci test pass on linux? the port haven't been changed after it added, so it should detact the failure before, however the CI test pass, and we merged the changes, it cause failrues in CI baseline .

Failures:
CMake Error at /home/phoebe/vcpkg/downloads/tools/cmake-3.14.0-linux/cmake-3.14.0-Linux-x86_64/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find KERBEROS (missing: KERBEROS_LIBRARIES KERBEROS_INCLUDE_DIR)
Call Stack (most recent call first):
/home/phoebe/vcpkg/downloads/tools/cmake-3.14.0-linux/cmake-3.14.0-Linux-x86_64/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
CMake/FindKERBEROS.cmake:21 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
/home/phoebe/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package)
CMakeLists.txt:20 (FIND_PACKAGE)

@kreuzerkrieg
Copy link
Contributor

@PhoebeHui First, I have no idea. Second I can try and ask folks from libhdfs. And third, I guess the answer is no, it makes perfect sense - want authentication? go for gsasl, using sasl? you need kerberos.

As of making ports, gsasl and kerberos last releases were issued a century before I've born, not sure anyone needs this port, honestly I dont see any reason for making port for a package that may be provided by native package management.

@strega-nil
Copy link
Contributor

strega-nil commented Mar 13, 2020

@kreuzerkrieg unfortunately, afaict, Ubuntu doesn't have kerberos :/

edit: no, I'm a dummy. Let's try it.

@kreuzerkrieg
Copy link
Contributor

krb5 AFAIR

@PhoebeHui
Copy link
Contributor

Thank you all for taking look at this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants