[boost-modular-build-helper] Support Clang '--target=<value>' syntax to enable Android builds#10285
Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom Apr 24, 2020
mschofie:mschofie/10091-android-boost
Merged
[boost-modular-build-helper] Support Clang '--target=<value>' syntax to enable Android builds#10285ras0219-msft merged 3 commits intomicrosoft:masterfrom mschofie:mschofie/10091-android-boost
ras0219-msft merged 3 commits intomicrosoft:masterfrom
mschofie:mschofie/10091-android-boost
Conversation
… enable Android builds (#10091)
Contributor
|
Regression is not related to the modification of the current PR, and I will be retested after the merger of #10290. |
Contributor
|
/azp run |
JackBoosY
suggested changes
Mar 4, 2020
Contributor
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Could you update port boost-modular-build-helper version info?
See documentation.
JackBoosY
approved these changes
Mar 5, 2020
Contributor
|
Will rerun linux PR test after |
Contributor
|
/azp run |
1 similar comment
Contributor
|
/azp run |
Contributor
|
Some |
This was referenced Mar 26, 2020
Contributor
|
/azp run |
Contributor
|
/azp run |
JackBoosY
approved these changes
Apr 15, 2020
JackBoosY
added
the
info:needs-maintainer-attention
Contributor
|
This LGTM, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
boost-modular-build-helperbuilds aCXXFLAGSvariable (containinguser-config.jamcompiler command-line options) to pass tob2. WhenCMAKE_CXX_COMPILER_TARGETis specified (which it is for Android builds) then theCXXFLAGSvalue is appended with<compileflags>${CMAKE_CXX_COMPILE_OPTIONS_TARGET} <compileflags>${CMAKE_CXX_COMPILER_TARGET}, which is correct for gcc's command-line options. But Clang expects no space between${CMAKE_CXX_COMPILE_OPTIONS_TARGET}and${CMAKE_CXX_COMPILER_TARGET}. In order to build for Clang this PR adds aCMAKE_CXX_COMPILER_IDcheck forClangand composes the variables in the Clang-specific manner.What does your PR fix? Fixes issue boost-exception:x64-android build failure #10091
Which triplets are supported/not supported? Have you updated the CI baseline? There aren't any 'android' triplets at the minute. I've buddy built this change locally successfully using Android NDK 20.1.5948994 and 21.0.6113669 on Windows.
Does your PR follow the maintainer guide? Yes.