Skip to content

[depend-info] Turn errors into warnings when querying dependencies of unsupported triplet #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strega-nil-ms merged 3 commits into from
Dec 15, 2021
Merged

[depend-info] Turn errors into warnings when querying dependencies of unsupported triplet #300

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a62153
[depend-info] Support option --allow-unsupported
Dec 13, 2021
ef0fe94
Add more notify message
Dec 13, 2021
7856b1d
Remove --allow-unsupported, print message as warning instead.
Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/vcpkg/commands.dependinfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,12 @@ namespace vcpkg::Commands::DependInfo
// By passing an empty status_db, we should get a plan containing all dependencies.
// All actions in the plan should be install actions, as there's no installed packages to remove.
StatusParagraphs status_db;
auto action_plan =
Dependencies::create_feature_install_plan(provider, var_provider, specs, status_db, {host_triplet});
auto action_plan = Dependencies::create_feature_install_plan(
provider, var_provider, specs, status_db, {host_triplet, Dependencies::UnsupportedPortAction::Warn});
for (const auto& warning : action_plan.warnings)
{
print2(Color::warning, warning, '\n');
}
Checks::check_exit(
VCPKG_LINE_INFO, action_plan.remove_actions.empty(), "Only install actions should exist in the plan");
std::vector<const InstallPlanAction*> install_actions =
Expand Down