[depend-info] Turn errors into warnings when querying dependencies of unsupported triplet#300
Conversation
BillyONeal
left a comment
There was a problem hiding this comment.
+1 -- I would go even farther and just make this the default. depend-info is not a system-mutating operation and does not take appreciable time so blocking the unsupported entries isn't really useful.
unless you want to know why something in CI is skipped. |
We should still be printing the warning, we just shouldn't block other depend-info data when the warning happens. |
|
@BillyONeal Sadly, if we always set it to vcpkg-tool/src/vcpkg/dependencies.cpp Line 894 in 8553f67 So I modifed this line to: print2(Color::warning, msg + "\n");But I don't know if it will affect the follow-up process. |
Don't do that. Do it like here and print the warnings that were returned by |
|
@BillyONeal Can we merge this now? |
In PR #184, we terminate the command early according to the
supportsfield inCONTROL/vcpkg.json, which affects the commanddepend-info, and it does not support the parameter--allow-unsupported.Now these error messages are always treated as warnings.