Skip to content

[vcpkg] Do not immediately fail at runtime if no Visual Studio has been found#12

Merged
ras0219-msft merged 2 commits intomicrosoft:mainfrom
ras0219:dev/roschuma/no-vs
Feb 17, 2021
Merged

[vcpkg] Do not immediately fail at runtime if no Visual Studio has been found#12
ras0219-msft merged 2 commits intomicrosoft:mainfrom
ras0219:dev/roschuma/no-vs

Conversation

@ras0219
Copy link
Contributor

@ras0219 ras0219 commented Feb 16, 2021

Previously, when users needed to bootstrap vcpkg with a copy of VS, this code was essentially never hit. Now that we are able to download a vcpkg binary, the user may only have non-Retail copies of MSVC or perhaps MinGW/Clang.

@ras0219-msft ras0219-msft merged commit 7434c2c into microsoft:main Feb 17, 2021
@ras0219 ras0219 deleted the dev/roschuma/no-vs branch February 17, 2021 02:20
vicroms added a commit to vicroms/vcpkg-tool that referenced this pull request Aug 28, 2025
@vicroms
# This is a combination of 30 commits.
2c4a760 
# This is the 1st commit message:

WIP

# The commit message #2 will be skipped:

# Fix build error

# The commit message microsoft#3 will be skipped:

# Implement bulk operation

# The commit message microsoft#4 will be skipped:

# Remove unused struct

# The commit message microsoft#5 will be skipped:

# Follow redirects

# The commit message microsoft#6 will be skipped:

# Get HTTP response code

# The commit message microsoft#7 will be skipped:

# Map URL response code to the correct index

# The commit message microsoft#8 will be skipped:

# Map URL response code to the correct index

# The commit message microsoft#9 will be skipped:

# Undo changes to workflows

# The commit message microsoft#10 will be skipped:

# Implement store to asset cache

# The commit message microsoft#11 will be skipped:

# handle file:// protocol

# The commit message microsoft#12 will be skipped:

# Implement try_download_file

# The commit message microsoft#13 will be skipped:

# Add missing calls to curl_easy_cleanup

# The commit message microsoft#14 will be skipped:

# Fix global init

# The commit message microsoft#15 will be skipped:

# Replace all calls in downloads.cpp and fix unit tests

# The commit message microsoft#16 will be skipped:

# use libcurl to submit metrics payload

# The commit message microsoft#17 will be skipped:

# Use Schannel on Windows

# The commit message microsoft#18 will be skipped:

# Apply suggestions from code review
#
# Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

# The commit message microsoft#19 will be skipped:

# Fix unit test

# The commit message microsoft#20 will be skipped:

# Change curl error messages

# The commit message microsoft#21 will be skipped:

# generate message map

# The commit message microsoft#22 will be skipped:

# Always call multi_remove_handle

# The commit message microsoft#23 will be skipped:

# Fix end-to-end tests

# The commit message microsoft#24 will be skipped:

# Cleanup header lists

# The commit message microsoft#25 will be skipped:

# curl global init order

# The commit message microsoft#26 will be skipped:

# Use external libcurl on non-Windows

# The commit message microsoft#27 will be skipped:

# Install libcurl4 dev package on Linux

# The commit message microsoft#28 will be skipped:

# Disable metrics by default in debug builds

# The commit message microsoft#29 will be skipped:

# Set user agent using CURLOPT_USERAGENT

# The commit message microsoft#30 will be skipped:

# curl initialization again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@strega-nil strega-nil strega-nil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ras0219 @strega-nil @ras0219-msft