Delete CurlRequestPrivateData#2
Merged
vicroms merged 3 commits intovicroms:link-libcurlfrom Oct 30, 2025
Merged
Conversation
BillyONeal
commented
Oct 29, 2025
| std::vector<CurlRequestPrivateData> private_data; | ||
| private_data.reserve(urls.size()); | ||
| std::vector<WriteFilePointer> write_pointers; | ||
| write_pointers.reserve(urls.size()); |
Author
There was a problem hiding this comment.
Note that this reserve is now load bearing to avoid the vector reallocating and changing the addresses of the WriteFilePointers. Might be worth a comment.
1 task
vicroms
added a commit
that referenced
this pull request
Nov 18, 2025
* add and link libcurl * Replace curl executable with libcurl API calls * Fix FindLibCURL for builds wihthout network access * Remove winHttp * Restore progress function * Handle non-dl transfer progress * Remove unused WinHttp code * Format and regenerate messages * Fix exepected console output of end-to-end test for multiple authoritative URLs in Windows * Remove unused parameter * Remove unused parameters 2 * Format and regenerate messages * Fix curl info read loop * Fix warnings and remove unused messages * Update src/vcpkg/binarycaching.cpp Co-authored-by: Billy O'Neal <bion@microsoft.com> * Delete CurlRequestPrivateData (#2) * PR comments WIP * Format and regenerate messages * Fix download retry * More review comments * Handle response code from file:// downloads/ * Update end-to-end test expected output * Fix download progress * Add curl license and notices * Fix call to upload metrics * Fix expected output comparison with newer versions of libcurl * Fix expected output comparison with newer versions of libcurl * Apply suggestions from code review Co-authored-by: Billy O'Neal <bion@microsoft.com> Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com> * More PR comments * Disable curl examples and fix out-of-bounds access in retry loop --------- Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com> Co-authored-by: Billy O'Neal <bion@microsoft.com> Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review comments, will be posted to microsoft#1660