Add missing encode/duration test coverage for *LargerUnit seconds scenarios#9965
Closed
Add missing encode/duration test coverage for *LargerUnit seconds scenarios#9965
*LargerUnit seconds scenarios#9965Conversation
…unit seconds scenarios Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add missing tests for encode duration functionality
Add missing encode/duration test coverage for Mar 9, 2026
*LargerUnit seconds scenarios
microsoft-github-policy-service
bot
added
the
emitter:client:java
weidongxu-microsoft
approved these changes
Mar 9, 2026
weidongxu-microsoft
requested review from
XiaofeiCao,
anuchandy,
haolingdong-msft and
srnagar
as code owners
Collaborator
|
You can try these changes here
|
Contributor
|
require publish of the fix #9945 |
auto-merge was automatically disabled
March 11, 2026 05:39
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncodeDurationTests.javawas missing test calls for theint32SecondsLargerUnitandfloatSecondsLargerUnitscenarios defined in the http-specs encode/duration spec, leaving 6 scenario paths untested.Changes
testQuery()— addsint32SecondsLargerUnit(Duration.ofMinutes(2))(expectsinput=120) andfloatSecondsLargerUnit(Duration.ofMinutes(2).plusSeconds(30))(expectsinput=150.0)testHeader()— same two calls for header encoding (duration: 120,duration: 150.0)testProperty()— adds round-trip assertions forInt32SecondsLargerUnitDurationPropertyandFloatSecondsLargerUnitDurationPropertyInt32SecondsLargerUnitDurationProperty,FloatSecondsLargerUnitDurationProperty)The previously commented-out
floatMilliseconds/float64Millisecondscases are intentionally left as-is (known serialization issue: sends35625.0instead of35625).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.