Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values supporting scalar and object #4423

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Default values supporting scalar and object #4423

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
90f0998
Default scalar value
AlitzelMendez Sep 12, 2024
606bb92
Add default type management for scalar value and object value
AlitzelMendez Sep 12, 2024
19dd478
Summary change
AlitzelMendez Sep 12, 2024
96e0957
Fix test and small details
AlitzelMendez Sep 12, 2024
0b0fc78
Merge branch 'main' into almend/ScalarDefaultValue
AlitzelMendez Sep 12, 2024
37e100c
Add test for known scalar
AlitzelMendez Sep 13, 2024
11c3457
Merge branch 'main' into almend/ScalarDefaultValue
AlitzelMendez Sep 13, 2024
efd04df
Feedback: Fix test
AlitzelMendez Sep 13, 2024
fe24cb7
Fedback: Add test and add enconding for scalar value
AlitzelMendez Sep 14, 2024
74de5c2
Merge branch 'main' into almend/ScalarDefaultValue
AlitzelMendez Sep 14, 2024
a57e728
Merge branch 'main' into almend/ScalarDefaultValue
AlitzelMendez Sep 16, 2024
9053872
Simplify use of mmodel property
AlitzelMendez Sep 16, 2024
90b63e8
Merge branch 'main' into almend/ScalarDefaultValue
AlitzelMendez Sep 16, 2024
efcf12c
Merge branch 'main' into almend/ScalarDefaultValue
AlitzelMendez Sep 17, 2024
c1794b9
Simplify code
AlitzelMendez Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/openapi3/test/primitive-types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,19 @@ describe("openapi3: primitives", () => {
expect(res.schemas.Pet.properties.name.default).toEqual("Shorty");
});

it("known scalar used as a default value", async () => {
const res = await oapiForModel(
"Test",
`
model Test { minDate: utcDateTime = utcDateTime.fromISO("2024-01-2T3:04:05Z"); }
`
);

expect(res.schemas.Test.properties.minDate.default).toEqual("2024-01-2T3:04:05Z");
AlitzelMendez marked this conversation as resolved.
Show resolved Hide resolved
expect(res.schemas.Test.properties.minDate.format).toEqual("date-time");
expect(res.schemas.Test.properties.minDate.type).toEqual("string");
AlitzelMendez marked this conversation as resolved.
Show resolved Hide resolved
});

it("object value used as a default value", async () => {
const res = await oapiForModel(
"Test",
Expand Down
Loading