Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values supporting scalar and object #4423

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Default values supporting scalar and object #4423

merged 15 commits into from
Sep 17, 2024

Conversation

AlitzelMendez
Copy link
Contributor

@AlitzelMendez AlitzelMendez commented Sep 12, 2024 •
edited
Loading

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:openapi3 Issues for @typespec/openapi3 emitter label Sep 12, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 12, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/openapi3
Show changes

@typespec/openapi3 - feature ✏️

Added support to use Scalar and Object as default types

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez changed the title [WIP] Default scalar value Default values supporting scalar and object Sep 13, 2024
@AlitzelMendez AlitzelMendez marked this pull request as ready for review September 13, 2024 00:25
@AlitzelMendez AlitzelMendez added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 9a28a9c Sep 17, 2024
22 checks passed
@AlitzelMendez AlitzelMendez deleted the almend/ScalarDefaultValue branch September 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
emitter:openapi3 Issues for @typespec/openapi3 emitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlitzelMendez @azure-sdk @timotheeguerin