MissingMethodException Fix #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acesiddhu
reviewed
Jan 24, 2019
| get | ||
| { | ||
| return this.properties as IDictionary; | ||
| return this.properties as IDictionary<string, object>; |
Contributor
There was a problem hiding this comment.
is.properties as IDictionary<string, object [](start = 25, length = 43)
just return this.properties.
acesiddhu
reviewed
Jan 24, 2019
| /// Gets test properties for a test. | ||
| /// </summary> | ||
| public abstract IDictionary Properties { get; } | ||
| public abstract IDictionary<string, object> Properties { get; } |
Contributor
There was a problem hiding this comment.
abstract [](start = 15, length = 8)
I am afraid if this is a breaking change?
Contributor
There was a problem hiding this comment.
if folks have taken a depedency in their code for this property and they expect IDict then build will fail
In reply to: 250584995 [](ancestors = 250584995)
Contributor
Author
There was a problem hiding this comment.
We will release a beta package and see if get any such feedback on this change.
Contributor
|
Update the Description. |
jayaranigarg
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a test project compiled for netstandard, and running in full framework throws the following error:
Error: System.MissingMethodException: Method not found: 'System.Collections.Generic.IDictionary`2<System.String,System.Object> Microsoft.VisualStudio.TestTools.UnitTesting.TestContext.get_Properties()'..
It is expecting IDictionary`2<System.String,System.Object> hence causing run time error.