Skip to content

MissingMethodException Fix #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2019
Merged

MissingMethodException Fix #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b86fc84
MissingMethodException Fix
vagisha-nidhi Jan 24, 2019
85ddefa
Fixing DesktopTestContextImplTests
vagisha-nidhi Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Adapter/PlatformServices.Desktop/Services/DesktopTestContextImplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ public override DataRow DataRow
}

/// <inheritdoc/>
public override IDictionary Properties
public override IDictionary<string, object> Properties
{
get
{
return this.properties as IDictionary;
return this.properties;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/TestFramework/Extension.Desktop/TestContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace Microsoft.VisualStudio.TestTools.UnitTesting
{
using System;
using System.Collections;
using System.Collections.Generic;
using System.Data;
using System.Data.Common;
using System.Diagnostics;
Expand All @@ -19,7 +19,7 @@ public abstract class TestContext
/// <summary>
/// Gets test properties for a test.
/// </summary>
public abstract IDictionary Properties { get; }
public abstract IDictionary<string, object> Properties { get; }
Copy link
Contributor

@acesiddhu acesiddhu Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstract [](start = 15, length = 8)

I am afraid if this is a breaking change?

Copy link
Contributor

@acesiddhu acesiddhu Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if folks have taken a depedency in their code for this property and they expect IDict then build will fail

In reply to: 250584995 [](ancestors = 250584995)

Copy link
Contributor Author

@vagisha-nidhi vagisha-nidhi Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will release a beta package and see if get any such feedback on this change.


/// <summary>
/// Gets the current data row when test is used for data driven testing.
Expand Down
10 changes: 5 additions & 5 deletions test/UnitTests/PlatformServices.Desktop.Unit.Tests/Services/DesktopTestContextImplTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ public void TestContextConstructorShouldInitializeDefaultProperties()
Assert.IsNotNull(this.testContextImplementation.Properties);

CollectionAssert.Contains(
this.testContextImplementation.Properties,
this.testContextImplementation.Properties.ToList(),
new KeyValuePair<string, object>("FullyQualifiedTestClassName", "A.C.M"));
CollectionAssert.Contains(
this.testContextImplementation.Properties,
this.testContextImplementation.Properties.ToList(),
new KeyValuePair<string, object>("TestName", "M"));
}

Expand Down Expand Up @@ -115,8 +115,8 @@ public void PropertiesShouldReturnPropertiesPassedToTestContext()

this.testContextImplementation = new TestContextImplementation(this.testMethod.Object, new System.IO.StringWriter(), this.properties);

CollectionAssert.Contains(this.testContextImplementation.Properties, property1);
CollectionAssert.Contains(this.testContextImplementation.Properties, property2);
CollectionAssert.Contains(this.testContextImplementation.Properties.ToList(), property1);
CollectionAssert.Contains(this.testContextImplementation.Properties.ToList(), property2);
}

[TestMethod]
Expand Down Expand Up @@ -162,7 +162,7 @@ public void AddPropertyShouldAddPropertiesToThePropertyBag()
this.testContextImplementation.AddProperty("SomeNewProperty", "SomeValue");

CollectionAssert.Contains(
this.testContextImplementation.Properties,
this.testContextImplementation.Properties.ToList(),
new KeyValuePair<string, object>("SomeNewProperty", "SomeValue"));
}

Expand Down