Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG currently doesn't work; using .jpg instead #2443

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

MikeTheGreat
Copy link
Contributor

Summary of the Pull Request

Docs show example config with with a background image
That image is listed as being .SVG
SVG currently doesn't work
Let's have the docs use .jpg instead

Since the JPG won't stretch nicely we're also going to put it in the top-right corner without any scaling

References

We can go back to an SVG file after #2441 gets fixed

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Detailed Description of the Pull Request / Additional comments

No additional comments

Validation Steps Performed

I looked at it in the 'Preview' panel

Since the JPG won't stretch nicely we're also going to put it in the top-right corner without any scaling
@WSLUser
Copy link
Contributor

WSLUser commented Aug 16, 2019

I personally prefer pngs over jpgs. Pngs are typically better quality images though that doesn't have to be the case. Did you ever check if the stretching works for png vice jpg?

@MikeTheGreat
Copy link
Contributor Author

I, too, prefer .PNGs (because of the transparent backgrounds) :) I left the .JPG in the docs to minimize changes.

The stretching DID work for .JPG. It looked horrible (my window size was way bigger than the image) but it worked.

Transparent .PNGs in the top-right corner for the win!

@zadjii-msft zadjii-msft added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Aug 19, 2019
@DHowett-MSFT DHowett-MSFT merged commit e92efa5 into microsoft:master Aug 20, 2019
@DHowett-MSFT
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants