Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal cannot use SVG files in backgroundImage, icon (xaml limitation?) #2441

Open
Tracked by #9995
MikeTheGreat opened this issue Aug 15, 2019 · 5 comments
Open
Tracked by #9995
Labels
Area-Settings Issues related to settings and customizability, for console or terminal External-Blocked-WinUI3 We can't progress until WinUI3 exists. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone

Comments

@MikeTheGreat
Copy link
Contributor

MikeTheGreat commented Aug 15, 2019

Over at UsingJsonSettings.md, in the section about adding a background image it directs me to download the .SVG image in Step 1

Step 4 then says to use the .JPG: ( "backgroundImage": "ms-appdata:///Roaming/openlogo.jpg", ) but this doesn't display the image in the Terminal.

Changing Step 4 to use the .SVG also doesn't display the image

Changing the file to be an actual .JPG (downloaded from the Debian logo page ) causes the image to appear.

The docs definitely need to be tweaked :)
(I'm not sure if .SVG is supposed to work or not, otherwise I'd do a PR to offer a fix)

@MikeTheGreat MikeTheGreat added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Aug 15, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 15, 2019
@DHowett-MSFT
Copy link
Contributor

It should probably work.

@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs labels Aug 15, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 15, 2019
@DHowett-MSFT DHowett-MSFT changed the title Terminal doesn't appear to support svg files Terminal cannot use SVG files in backgroundImage, icon (xaml limitation?) Aug 15, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 16, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Aug 16, 2019
@microsoft microsoft deleted a comment from ararif4947 Apr 21, 2020
@microsoft microsoft deleted a comment from ararif4947 Apr 21, 2020
@djsavvy
Copy link

djsavvy commented Jun 22, 2020

Just to counter @DHowett-MSFT, using an SVG icon does not in fact work. I'm guessing y'all are aware of this already, but I just want to make sure the latest comment on this thread reflects the current status.

@MikeTheGreat are you still interested/willing to make a PR for SVG support for icon/background files?

@MikeTheGreat
Copy link
Contributor Author

Thanks for the shout-out, @djsavvy :)

I'm busy until after August 8th so feel free to dig in on this if it's looking interesting to you.

After that I'd like to dig in on #5506 first, I think. (No promises there, either :) )

@DHowett
Copy link
Member

DHowett commented Jun 22, 2020

@djsavvy Just to be clear, I meant "Yeah this should probably be made to work" 😄

@marcelwgn
Copy link
Contributor

I'm afraid, supporting SVGs might not be that trivial due to the UWP Platform behaving quite strangely around them (e.g microsoft/microsoft-ui-xaml#825). When testing SVGs, the results were completely broken:

Screenshots of TV test image not being rendered properly

https://upload.wikimedia.org/wikipedia/commons/b/bd/Test.svg

Screenshot of Microsoft Logo rendering as solid yellowish block

https://upload.wikimedia.org/wikipedia/commons/4/44/Microsoft_logo.svg

There might not be much we can do to support this at this point I'm afraid beside looking for other ways to render SVGs beside the UWP Image control...

@zadjii-msft zadjii-msft added Tracking-External This bug isn't resolved, but it's following an external workitem. External-Blocked-WinUI3 We can't progress until WinUI3 exists. and removed Help Wanted We encourage anyone to jump in on these. labels Apr 15, 2024
@zadjii-msft zadjii-msft modified the milestones: Backlog, Icebox ❄ Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal External-Blocked-WinUI3 We can't progress until WinUI3 exists. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Development

No branches or pull requests

6 participants