[1.24] conhost: Make screen readers announce search results - #20533
Draft
Carlos Zamora (carlos-zamora) wants to merge 1 commit into
Draft
[1.24] conhost: Make screen readers announce search results#20533Carlos Zamora (carlos-zamora) wants to merge 1 commit into
Carlos Zamora (carlos-zamora) wants to merge 1 commit into
Conversation
check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.Unrecognized words (780)These words are not needed and should be removedAPCs bitmasks changelists clsids Cmts codepages COLORREFs colorschemes distros DPIs DWORDs ESFCIB flyouts foob frontends Fullscreens fuzzyfinder Ioctl keydowns keyups lstrcmpi noexcepts nullopts OEMs oob pdbs popups reparented rgbs scancodes screenshots subkeys testenvs titlebars toolbars UChars UINTs unittests wchars websites wstrings xamls ZWJsSome files were automatically ignored 🙈These sample patterns would exclude them: You should consider adding them to: File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct, update file exclusions, and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:microsoft/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/31443821264/attempts/1' &&
git commit -m 'Update check-spelling metadata'Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (2080) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt and unrecognized words (780)
Consider adding to the "cspell:software-terms/dict/softwareTerms.txt",
"cspell:cpp/src/stdlib-cpp.txt",
"cspell:cpp/src/stdlib-c.txt",
"cspell:python/src/python/python-lib.txt",
"cspell:php/dict/php.txt",
To stop checking additional dictionaries, put (in the "check_extra_dictionaries": []Pattern suggestions ✂️ (5)You could add these patterns to Alternatively, if a pattern suggestion doesn't make sense for this project, add a Errors, Warnings, and Notices ❌ (5)See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.
See ❌ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug in console host where search results weren't being announced by the screen reader.
Adds 2 localized resources for announcements:
ID_CONSOLE_MSGFINDRESULT:"%1!d! of %2!d!"ID_CONSOLE_MSGFINDNORESULT:"No results"Updates the
AccessibilityNotifierwith a newAnnounceSearchResults()which handles making the announcements above usingUiaRaiseNotificationEvent()(similar to how we make similar announcements in Windows Terminal).The user experience itself is similar to Windows Terminal. The main difference being that Terminal announces the selection state after closing the search box (" selected"), and console host does not.
References and Relevant Issues
Port of #20532, with the following changes:
AccessibilityNotifieronmainstores the UIA provider and has a batching system. We don't really have to care about the batching system here. Additionally, rather than retrieving the UIA provider, we delegate the work usingWindow::SignalUiaAnnouncement()-->WindowUiaProvider::SignalAnnouncement()-->UiaRaiseNotificationEvent().Validation Steps Performed
Opened the search box and performed a search with...
✅ results --> "<1-indexed num> of "
✅no results --> "no results"
PR Checklist
Closes https://dev.azure.com/microsoft/OS/_workitems/edit/37170192/?view=edit