conhost: Make screen readers announce search results - #20532
Draft
Carlos Zamora (carlos-zamora) wants to merge 1 commit into
Draft
conhost: Make screen readers announce search results#20532Carlos Zamora (carlos-zamora) wants to merge 1 commit into
Carlos Zamora (carlos-zamora) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug in console host where search results weren't being announced by the screen reader.
Adds 2 localized resources for announcements:
ID_CONSOLE_MSGFINDRESULT:"%1!d! of %2!d!"ID_CONSOLE_MSGFINDNORESULT:"No results"Updates the
AccessibilityNotifierwith a newAnnounceSearchResults()which handles making the announcements above usingUiaRaiseNotificationEvent()(similar to how we make similar announcements in Windows Terminal).The user experience itself is similar to Windows Terminal. The main difference being that Terminal announces the selection state after closing the search box (" selected"), and console host does not.
References and Relevant Issues
Validation Steps Performed
Opened the search box and performed a search with...
✅ results --> "<1-indexed num> of "
✅no results --> "no results"
PR Checklist
Closes https://dev.azure.com/microsoft/OS/_workitems/edit/37170192/?view=edit