Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some default keybindings #2014

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jul 17, 2019

Closes #1417.

Changes New Tab to Ctrl+Shift+t (from Ctrl+t)
Changes SwitchToTabN to Ctrl+Alt+<number> (from Alt+<number>)

References

This is from discussion in #1417
#2012 Changes "Close Window" by removing it by default, and adding ClosePane on Ctrl+Shift+W

PR Checklist

  Closes #1417.

  Changes New Tab to Ctrl+Shift+t (from Ctrl+t)
  Changes SwitchToTabN to Ctrl+Alt+<number> (from Alt+<number>)
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve; perhaps we should ask some folks from the originating issue to pop in?

Copy link
Contributor

@WSLUser WSLUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I'm used to using CTRL sequences with other key combos so this makes a bunch of sense to me.

@inputfalken
Copy link

Definitely a better change! 👍

But perhaps a better modifier key should be the windows key with some additional key?

This would also make the terminal better coupled with Windows; in my opinion.

@DHowett-MSFT
Copy link
Contributor

Alas! The Windows key is for the exclusive use of Windows' shell. Win+W, Win+T, Win+Tab, Win+D all do things and they're intercepted before we get a chance to say "no!".

@inputfalken
Copy link

Alas! The Windows key is for the exclusive use of Windows' shell. Win+W, Win+T, Win+Tab, Win+D all do things and they're intercepted before we get a chance to say "no!".

Ah, I see.

@miniksa miniksa merged commit 260d095 into master Jul 23, 2019
@miniksa miniksa deleted the dev/migrie/f/1417-make-these-usual branch July 23, 2019 00:53
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
Closes microsoft#1417.

  Changes New Tab to Ctrl+Shift+t (from Ctrl+t)
  Changes SwitchToTabN to Ctrl+Alt+<number> (from Alt+<number>)
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 25, 2019
Closes microsoft#1417.

  Changes New Tab to Ctrl+Shift+t (from Ctrl+t)
  Changes SwitchToTabN to Ctrl+Alt+<number> (from Alt+<number>)
@ghost
Copy link

ghost commented Aug 3, 2019

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

@henrik-jensen
Copy link

henrik-jensen commented Aug 4, 2019

Just for discoverability/history:
The changes to the default shortcuts introduced a regression on first time installed v0.3.2142.0 discussed in issue 521, here the eureka by lhecker, and PR'ed by @lhecker in #2235. Workaround until #2235 is accepted/released - change your Ctrl+Alt+[0-9] shortcuts in profiles.json to something not using a Ctrl+Alt combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default bindings are unusual for people who expect them to be usual
6 participants