Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define size for background image #2370

Open
Tracked by #9995
sachabruttin opened this issue Aug 9, 2019 · 5 comments
Open
Tracked by #9995

Define size for background image #2370

sachabruttin opened this issue Aug 9, 2019 · 5 comments
Assignees
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@sachabruttin
Copy link

Description of the new feature/enhancement

As we are now able to define background image position using backgroundImageAlignment. It makes really easy to put an image to lower right of the terminal.
It will be very appreciated to also define the size of this image. It will help to place a large image in a corner of the terminal.

Proposed technical implementation details (optional)

Add properties into the profiles.json file: eg. backgroundImageWidth and backgroundImageHeight.

@sachabruttin sachabruttin added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 9, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 9, 2019
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Aug 9, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 9, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 9, 2019
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Aug 9, 2019
@DHowett-MSFT
Copy link
Contributor

I’m not sure. With trivial access to image editing tools, you can make an image whatever size you want, can’t you?

@sachabruttin
Copy link
Author

Sure I can, but it is much easier to change settings to define what is the good size of an image. By the way, i'm also missing properties to define margin or padding for the image.

In the image it's an animated gif, I have no tool on my machine to resize it. I had to turn to an online converter. If I want to add border, I have no idea which tool to use :-(

image

@trigger-segfault
Copy link
Contributor

As I can see, the pros are as follows:

  • Quality of life: On the fly image resizing when experimenting with the perfect background layout.
  • Easy to use: Allows for resizing animated gifs, which isn’t as easy as with static images.
  • Accessible: No requirements for external tools or websites to perform the resizing. This would benefit if Windows Terminal is being run on a work computer, and the user doesn’t have access to the tools (or maybe even websites) to resize an image.

The cons I see are:

  • Ambiguous: I’m assuming these proposed settings are designed to resize the base image. This is likely the easiest way to implement the feature as well. However, would it be confusing for the user when combining these image size settings with stretch mode?
  • Unnecessary: Image resizing can be performed with external tools. Unlike settings such as alignment, which are affected by dynamic window sizes and stretch mode, image size is something that is not affected by any of these in a way that requires the setting in order to obtain something new. This may be more relevant to Feature Request : Make BackgroundImage avaliable for websites #1936 where @zadjii-msft mentions that extensions could add background features that have less demand.

Animated Gif Resizing

There are cross platform tools such as FFmpeg and GIMP that support resizing animated gifs, although they may require looking up some examples.

Note on Padding

I do agree that a padding setting would be beneficial. The same display functionality cannot be completely mimicked through image manipulation and use of existing settings. However, again, image manipulation can closely mimic this as long as it’s acceptable for padding sizes to scale when using stretch modes other than none. Regardless, padding should be presented in its own issue.

@SWB54
Copy link

SWB54 commented Apr 23, 2020

When we define the background image size via this feature, we probably mean for that size to be interpreted as physical pixels. Currently, image dimensions are scaled according to the system UI scale (#5480).

@DualBrain
Copy link

I have two comments:

  1. In television there is the concept of a "bug" - a logo (image) that is displayed (typically) at the bottom right of the display. If there was a size mode that could be set to this, then it would automatically handle resize (as a percentage of the window) as well as any potential padding. Meaning, that this "area" would be fixed and whatever image you provide will be sized to this area - which the area would also resize in proportion to the current window size.

  2. The statement that this can be done using external tools doesn't address the fact that a console window can be resized and doesn't address those that have different machines with different monitor resolutions (laptop, desktop, remote desktop, etc.) - so resizing using external tools might address one machine and you'd not only have to have a different image per device, but potentially a different configuration setting for each device. It is my desire not to specify a pixel size... but a percentage of the window size - allowing for some semblance of device independence so that I can easily reuse the settings/images on multiple devices.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

7 participants