-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define size for background image #2370
Comments
I’m not sure. With trivial access to image editing tools, you can make an image whatever size you want, can’t you? |
Sure I can, but it is much easier to change settings to define what is the good size of an image. By the way, i'm also missing properties to define margin or padding for the image. In the image it's an animated gif, I have no tool on my machine to resize it. I had to turn to an online converter. If I want to add border, I have no idea which tool to use :-( |
As I can see, the pros are as follows:
The cons I see are:
Animated Gif Resizing There are cross platform tools such as FFmpeg and GIMP that support resizing animated gifs, although they may require looking up some examples. Note on Padding I do agree that a padding setting would be beneficial. The same display functionality cannot be completely mimicked through image manipulation and use of existing settings. However, again, image manipulation can closely mimic this as long as it’s acceptable for padding sizes to scale when using stretch modes other than |
When we define the background image size via this feature, we probably mean for that size to be interpreted as physical pixels. Currently, image dimensions are scaled according to the system UI scale (#5480). |
I have two comments:
Thanks. |
Description of the new feature/enhancement
As we are now able to define background image position using
backgroundImageAlignment
. It makes really easy to put an image to lower right of the terminal.It will be very appreciated to also define the size of this image. It will help to place a large image in a corner of the terminal.
Proposed technical implementation details (optional)
Add properties into the profiles.json file: eg.
backgroundImageWidth
andbackgroundImageHeight
.The text was updated successfully, but these errors were encountered: