Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Background Flip #3452

Closed
bobfrankly opened this issue Nov 6, 2019 · 4 comments
Closed

Feature Request - Background Flip #3452

bobfrankly opened this issue Nov 6, 2019 · 4 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.

Comments

@bobfrankly
Copy link

bobfrankly commented Nov 6, 2019

Description of the new feature/enhancement

Some animated gifs have motion on a specific side of the image. When the motion is focused to the right edge of the screen, this tends to work well, but when the motion is on the left side, it may be too much. An option to flip the background would add flexibility in such situations.
Examples:

Proposed technical implementation details (optional)

Add to the profiles.json spec: backgroundImageFlip with options for horizontal and vertical, and the functional code that would implement this feature.

Obvious flattery

Loving the product so far! -Bob

@bobfrankly bobfrankly added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 6, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 6, 2019
@DHowett-MSFT
Copy link
Contributor

Flattery

thanks!

(flip)

I'm concerned about the overhead of having the terminal (or the XAML image control, really) flip the image every time it's displayed when you could save your computer time and processing power by pre-flipping the gif you'd like to use 😄

We had a discussion like this in #2370, but never reached a consensus.

@bobfrankly
Copy link
Author

Flattery

thanks!

(flip)

I'm concerned about the overhead of having the terminal (or the XAML image control, really) flip the image every time it's displayed when you could save your computer time and processing power by pre-flipping the gif you'd like to use 😄

We had a discussion like this in #2370, but never reached a consensus.

Now I'm just a powershell junkie, so I'm admittedly not familiar with the details, but would the overhead for a flip that considerable compared to the automatic scaling and alignment that's already included?

I get the mentality behind 'modify and save locally', but the idea of 'copy and paste these few lines and my config is over here now' is a strong contender as well 😄

@egmontkob
Copy link

The two cents of someone who doesn't even use this software (that is, me):

Adding such a feature opens up a can of worms for an endless number of similar tiny ones: rotating by 90° or arbitrary angle, applying arbitrary matrix transformation, blurring, various kinds of color corrections and so on and so forth.

The only consistent and non-arbitrary place to draw a line is to include only the ones absolutely necessary, the ones which cannot be done externally because depend on the current size of the terminal (that is: scaling, stretching or cropping, aligning, tiling).

@DHowett-MSFT
Copy link
Contributor

I think that's a really good assessment. Thanks @egmontkob! I'm going to have to veto this one, but I'm still open to a discussion about the merits of various background image options. 😸

@DHowett-MSFT DHowett-MSFT added Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Projects
None yet
Development

No branches or pull requests

3 participants