Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting a tab should offer profiles like it used to #17684

Closed
inosik opened this issue Aug 8, 2024 · 2 comments
Closed

Splitting a tab should offer profiles like it used to #17684

inosik opened this issue Aug 8, 2024 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@inosik
Copy link

inosik commented Aug 8, 2024

Description of the new feature/enhancement

The "Split pane" command used to have a submenu, where you could select the profile for the new pane:

WindowsTerminal_2024-08-08_15-32-52

Right now I have no idea how to create a new pane using a profile that is not the default one.
@inosik inosik added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 8, 2024
@carlos-zamora
Copy link
Member

Oh no... This is another manifestation of #17294.

I'm guessing you added a plain "command": "splitPane" to your settings.json. We expose that as Split pane in the command palette.

In #16886, the key for the nested action got renamed from Split Pane... to Split pane. This accidentally caused a collision because now you have two actions with the same name! The settings model then prefers your action over the one defined in defaults.json, thus completely hiding the nested version.

I'm marking this a /dup of #17294 and reverting the ... changes in the names. That should make these come back 😊

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 14, 2024
@carlos-zamora carlos-zamora mentioned this issue Aug 14, 2024
Merged
@inosik
Copy link
Author

inosik commented Aug 16, 2024 •
edited
Loading

I'm guessing you added a plain "command": "splitPane" to your settings.json

You're right, there was an action that was bound to this command. I'm not aware of ever adding it though.

However, I removed it and the submenu is back, thanks!

DHowett pushed a commit that referenced this issue Aug 21, 2024
@carlos-zamora
Add ellipses back in to some command names (#17715)
0a7c258 
In #16886, the key for the nested action got renamed from `Split
Pane...` to `Split pane`. This accidentally caused a collision because
now there's two actions with the same name! The settings model then
prefers the user's action over the one defined in defaults.json, thus
completely hiding the nested version.

I tried to balance the stylistic recommendations from #16846 (mainly
[this
comment](#16846 (comment))
since it gave some excellent examples) while trying to maintain muscle
memory as much as possible (with similar substring sequences). There was
also one case where we still used "the tab" so I removed the "the" for
consistency.

Side effect of #16886 which closed #16846
Closes #17294
Closes #17684
DHowett pushed a commit that referenced this issue Aug 21, 2024
@carlos-zamora @DHowett
Add ellipses back in to some command names (#17715)
8aa56c2 
In #16886, the key for the nested action got renamed from `Split
Pane...` to `Split pane`. This accidentally caused a collision because
now there's two actions with the same name! The settings model then
prefers the user's action over the one defined in defaults.json, thus
completely hiding the nested version.

I tried to balance the stylistic recommendations from #16846 (mainly
[this
comment](#16846 (comment))
since it gave some excellent examples) while trying to maintain muscle
memory as much as possible (with similar substring sequences). There was
also one case where we still used "the tab" so I removed the "the" for
consistency.

Side effect of #16886 which closed #16846
Closes #17294
Closes #17684

(cherry picked from commit 0a7c258)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSFdXc
Service-Version: 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlos-zamora @inosik