Skip to content

Commit 0a7c258

Browse files
Add ellipses back in to some command names (#17715)
In #16886, the key for the nested action got renamed from `Split Pane...` to `Split pane`. This accidentally caused a collision because now there's two actions with the same name! The settings model then prefers the user's action over the one defined in defaults.json, thus completely hiding the nested version. I tried to balance the stylistic recommendations from #16846 (mainly [this comment](#16846 (comment)) since it gave some excellent examples) while trying to maintain muscle memory as much as possible (with similar substring sequences). There was also one case where we still used "the tab" so I removed the "the" for consistency. Side effect of #16886 which closed #16846 Closes #17294 Closes #17684
1 parent a40a4ea commit 0a7c258

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw

+8-11
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@
118118
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119119
</resheader>
120120
<data name="SetColorSchemeParentCommandName" xml:space="preserve">
121-
<value>Select color scheme</value>
121+
<value>Select color scheme...</value>
122122
</data>
123123
<data name="NewTabParentCommandName" xml:space="preserve">
124-
<value>New tab</value>
124+
<value>New tab...</value>
125125
</data>
126126
<data name="SplitPaneParentCommandName" xml:space="preserve">
127-
<value>Split pane</value>
127+
<value>Split pane...</value>
128128
</data>
129129
<data name="SnippetsPaneCommandName" xml:space="preserve">
130130
<value>Open snippets pane</value>
@@ -329,7 +329,7 @@
329329
<comment>{Locked="JSON"}. "JSON" is the extension of the file that will be opened.</comment>
330330
</data>
331331
<data name="OpenTabColorPickerCommandKey" xml:space="preserve">
332-
<value>Set the tab color</value>
332+
<value>Set tab color...</value>
333333
</data>
334334
<data name="PasteTextCommandKey" xml:space="preserve">
335335
<value>Paste</value>
@@ -351,7 +351,7 @@
351351
<value>Reset tab title</value>
352352
</data>
353353
<data name="OpenTabRenamerCommandKey" xml:space="preserve">
354-
<value>Rename tab title</value>
354+
<value>Rename tab</value>
355355
</data>
356356
<data name="ResizePaneCommandKey" xml:space="preserve">
357357
<value>Resize pane</value>
@@ -445,17 +445,14 @@
445445
<value>Switch to the last tab</value>
446446
</data>
447447
<data name="TabSearchCommandKey" xml:space="preserve">
448-
<value>Search for tab</value>
448+
<value>Search for tab...</value>
449449
</data>
450450
<data name="ToggleAlwaysOnTopCommandKey" xml:space="preserve">
451451
<value>Toggle always on top mode</value>
452452
</data>
453453
<data name="ToggleCommandPaletteCommandKey" xml:space="preserve">
454454
<value>Toggle command palette</value>
455455
</data>
456-
<data name="SuggestionsCommandHistoryCommandKey" xml:space="preserve">
457-
<value>Recent commands</value>
458-
</data>
459456
<data name="SuggestionsCommandKey" xml:space="preserve">
460457
<value>Open suggestions</value>
461458
</data>
@@ -519,7 +516,7 @@
519516
<value>Reset window name</value>
520517
</data>
521518
<data name="OpenWindowRenamerCommandKey" xml:space="preserve">
522-
<value>Rename window</value>
519+
<value>Rename window...</value>
523520
</data>
524521
<data name="DisplayWorkingDirectoryCommandKey" xml:space="preserve">
525522
<value>Display Terminal's current working directory</value>
@@ -570,7 +567,7 @@
570567
<value>Quit the Terminal</value>
571568
</data>
572569
<data name="SetOpacityParentCommandName" xml:space="preserve">
573-
<value>Set background opacity</value>
570+
<value>Set background opacity...</value>
574571
</data>
575572
<data name="IncreaseOpacityCommandKey" xml:space="preserve">
576573
<value>Increase background opacity by {0}%</value>

0 commit comments

Comments
 (0)