Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush-lib] Fix filtered install behavior when there are dependencies on other subspaces #5019

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[rush-lib] Fix filtered install behavior when there are dependencies on other subspaces #5019

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46dcfa3
[rush] Fix install all projects in monorepo
pedro-gomes-92 Nov 26, 2024
cc3d74a
[rush] Update changelogs
pedro-gomes-92 Nov 26, 2024
cd3d6bd
Update common/changes/@microsoft/rush/pedrogomes-fix-install-all-proj…
pedro-gomes-92 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/pedrogomes-fix-install-all-projects_2024-11-26-04-35.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix install all projects of all subspaces in a monorepo",
pedro-gomes-92 marked this conversation as resolved.
Show resolved Hide resolved
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
3 changes: 3 additions & 0 deletions libraries/rush-lib/src/cli/actions/BaseInstallAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ export abstract class BaseInstallAction extends BaseRushAction {
console.log(Colorize.green(`Installing for subspace: ${subspace.subspaceName}`));
let installManagerOptionsForInstall: IInstallManagerOptions;
if (subspaceInstallationData) {
// This will install the selected of projects in the subspace
const { selectedProjects, pnpmFilterArgumentValues } = subspaceInstallationData;
installManagerOptionsForInstall = {
...installManagerOptions,
Expand All @@ -262,8 +263,10 @@ export abstract class BaseInstallAction extends BaseRushAction {
subspace
};
} else {
// This will install all projects in the subspace
installManagerOptionsForInstall = {
...installManagerOptions,
pnpmFilterArgumentValues: [],
subspace
};
}
Expand Down