[rush-lib] Fix filtered install behavior when there are dependencies on other subspaces

[pedro-gomes-92]

Summary

Fix install all projects of all subspaces in a monorepo

Details

What happened?

We have a project which depends on ALL of the rest of the local packages of different subspaces.

When we run rush install -t P1, all subspaces except the current, are ignored with the message: "No projects matched the filters in XXX".

In other words, NO dependencies are installed (node_modules folders are empty) for the cross-subspaces that the project requires.

Subspace S1 is installed, but S2 and S3 are not! Both S2 and S3 will show the message "No projects matched the filters in XXX".

What I expected to happen?

All related cross-subspaces should be properly installed. I would expect no message: "No projects matched the filters in XXX" to be shown.

The solution

After diagnosing the pnpm install command during a subspace installation, we discovered a package filtering parameter for the current project (e.g. --filter P1), which fails to exist on any cross-subspace dependency. PNPM will then skip each cross-subspace installation.

/XXX/.rush/node-v18.20.5/pnpm-8.8.0/node_modules/pnpm/bin/pnpm.cjs install --store /YYY/common/temp/pnpm-store --config.cacheDir=/YYY/common/temp/pnpm-store --config.stateDir=/YYY/common/temp/pnpm-store --frozen-lockfile --config.dedupe-peer-dependents=false --reporter ndjson --no-strict-peer-dependencies --config.auto-install-peers=false --config.resolutionMode=highest --config.ignoreCompatibilityDb --recursive --link-workspace-packages false --filter @P1...

This filter should NOT exist when Rush wants to install all projects of all subspaces.

How it was tested

1. Create a repository with subspaces enabled: https://rushjs.io/pages/advanced/subspaces/
2. Create 2 subspaces (e.g. default and s1)
3. Create a project inside of s1 and default and add s1 project as a local dependency of default
4. Run rush install -t <project_of_default>

The message "No projects matched the filters in XXX" during s1 installation.