[rush] Bring back the Variants feature. #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
D4N14L
reviewed
Sep 18, 2024
libraries/rush-lib/src/logic/installManager/RushInstallManager.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts
Outdated
Show resolved
Hide resolved
iclanton
force-pushed
the
bring-back-variants
branch
2 times, most recently
from
aecb55c to
1259fdc
Compare
D4N14L
approved these changes
Sep 20, 2024
|
This has been released as Rush version |
iclanton
force-pushed
the
bring-back-variants
branch
from
aa2b595 to
12186a2
Compare
|
A fix to this change was released as version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brings back the "Variants" feature that was removed in #4538.
Details
This feature was being used more than expected, and subspaces are currently not able to fill the gap.
This should probably be released as a prerelease.
How it was tested
Tested against https://github.com/Azure/communication-ui-library.
Impacted documentation
Abandoned microsoft/rushstack-websites#217