Skip to content

Commit

Permalink
Fix an issue with ensuring consistent versions with a default subspace.
Browse files Browse the repository at this point in the history
  • Loading branch information
iclanton committed Sep 22, 2024
1 parent 1259fdc commit aa2b595
Showing 1 changed file with 15 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,18 @@ export class VersionMismatchFinder {
terminal: ITerminal,
options?: IVersionMismatchFinderRushCheckOptions
): void {
const {
variant,
subspace = rushConfiguration.defaultSubspace,
printAsJson,
truncateLongPackageNameLists
} = options ?? {};

VersionMismatchFinder._checkForInconsistentVersions(rushConfiguration, {
subspace: rushConfiguration.defaultSubspace,
variant: undefined,
...options,
variant,
subspace,
printAsJson,
truncateLongPackageNameLists,
terminal,
isRushCheckCommand: true
});
Expand All @@ -85,10 +93,11 @@ export class VersionMismatchFinder {
terminal: ITerminal,
options?: IVersionMismatchFinderEnsureConsistentVersionsOptions
): void {
const { variant, subspace = rushConfiguration.defaultSubspace } = options ?? {};

VersionMismatchFinder._checkForInconsistentVersions(rushConfiguration, {
subspace: rushConfiguration.defaultSubspace,
variant: undefined,
...options,
subspace,
variant,
terminal,
isRushCheckCommand: false,
truncateLongPackageNameLists: true
Expand Down

0 comments on commit aa2b595

Please sign in to comment.