Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds more information to Rush's error reporting in phased commands, and ensures that more error messages are included in the summary view.
Details
afterExecuteOperation
handler throws an error, ensure that any existing error from the original process is reported to theOperationExecutionRecord
'sTerminal
instance andStdioSummarizer
.Operation
is reported to theOperationExecutionRecord
's Terminal instance andStdioSummarizer
.Unfortunately the error logging from pnpm-sync-lib still violates this contract, since it writes to the global terminal directly, but does so during
afterExecuteOperation
. See tiktok/pnpm-sync#31 and tiktok/pnpm-sync#32 for my suggested approach to address that case.How it was tested
Ran build under debugger and induced the following failure states:
beforeExecuteOperation
and verified that the error message appeared in the summary at the end of the buildafterExecuteOperation
and verified that the error message appeared in the summary at the end of the buildImpacted documentation
API documentation for
StdioSummarizer