Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm-sync-lib should allow callers to directly provide the content of .pnpm-sync.json #31

Open
dmichon-msft opened this issue May 15, 2024 · 0 comments

Comments

@dmichon-msft
Copy link

Existence checking a file before reading it (especially asynchronously) allows for the existence of the file to change between the two file system calls. Additionally, for integration with Rush multi-phase builds, the sync file contents will not change between phases in the same project, and thus by allowing the content to be passed directly, we can avoid duplicate reads when pnpm-sync will be called after each phase.

As an example, the rushstack repository has phases build and test for all projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant