Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test helper functions in rai_test_utils #1938

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Feb 3, 2023

Description

Add more test helper functions in rai_test_utils

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #1938 (8238142) into main (beed87f) will increase coverage by 0.92%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
+ Coverage   93.23%   94.16%   +0.92%     
==========================================
  Files          95       95              
  Lines        4701     4712      +11     
==========================================
+ Hits         4383     4437      +54     
+ Misses        318      275      -43     
Flag Coverage Δ
unittests 94.16% <100.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._test_utils/datasets/tabular/tabular_data_utils.py 100.00% <100.00%> (+64.17%) ⬆️
...st_utils/rai_test_utils/models/sklearn/__init__.py 100.00% <100.00%> (ø)
...i_test_utils/models/sklearn/sklearn_model_utils.py 71.42% <100.00%> (+3.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

gaugup and others added 5 commits February 6, 2023 16:25
… 1 (#1937)

* Migrate responsibleai tests to use utilities in rai_test_utils - Part 1

Signed-off-by: Gaurav Gupta <[email protected]>

* Add create_cancer_data

Signed-off-by: Gaurav Gupta <[email protected]>

* fix

Signed-off-by: Gaurav Gupta <[email protected]>

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Roman Lutz <[email protected]>
* Dataset explorer: Propagate number of bins to SDK backend API

Signed-off-by: Gaurav Gupta <[email protected]>

* Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts

Co-authored-by: Roman Lutz <[email protected]>

* Revert "Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts"

This reverts commit a8b2e42.

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Roman Lutz <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup gaugup enabled auto-merge (squash) February 7, 2023 00:27
1 similar comment
@gaugup gaugup merged commit 59c7fe4 into main Feb 7, 2023
@gaugup gaugup deleted the gaugup/AddNewAPIsRAITestUtils branch February 7, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants