Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate responsibleai tests to use utilities in rai_test_utils - Part 1 #1937

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Feb 2, 2023

Description

This is part 1 of the changes. For part 2, I need to add some more APIs/enhance existing ones in rai_test_utils.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #1937 (a2cb78e) into main (3f4fdf3) will increase coverage by 0.92%.
The diff coverage is n/a.

❗ Current head a2cb78e differs from pull request most recent head e689e0b. Consider uploading reports for the commit e689e0b to get more accurate results

@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
+ Coverage   92.35%   93.27%   +0.92%     
==========================================
  Files         105       95      -10     
  Lines        4958     4657     -301     
==========================================
- Hits         4579     4344     -235     
+ Misses        379      313      -66     
Flag Coverage Δ
unittests 93.27% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/feature_metadata.py 95.65% <0.00%> (-4.35%) ⬇️
responsibleai/responsibleai/__init__.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/rai_insights/constants.py 100.00% <0.00%> (ø)
..._core_flask/environments/databricks_environment.py
...re_flask/environments/local_ipython_environment.py
...ai_core_flask/environments/azure_nb_environment.py
...sk/rai_core_flask/environments/base_environment.py
rai_core_flask/rai_core_flask/__init__.py
..._flask/environments/credentialed_vm_environment.py
...i_core_flask/environments/public_vm_environment.py
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Gaurav Gupta <[email protected]>
1 similar comment
@gaugup gaugup merged commit 0130b45 into main Feb 6, 2023
@gaugup gaugup deleted the gaugup/MoveResponsibleAITestsRAITestUtils branch February 6, 2023 18:09
gaugup added a commit that referenced this pull request Feb 7, 2023
… 1 (#1937)

* Migrate responsibleai tests to use utilities in rai_test_utils - Part 1

Signed-off-by: Gaurav Gupta <[email protected]>

* Add create_cancer_data

Signed-off-by: Gaurav Gupta <[email protected]>

* fix

Signed-off-by: Gaurav Gupta <[email protected]>

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Roman Lutz <[email protected]>
gaugup added a commit that referenced this pull request Feb 7, 2023
* Add more test helper functions in rai_test_utils

Signed-off-by: Gaurav Gupta <[email protected]>

* Migrate responsibleai tests to use utilities in rai_test_utils - Part 1 (#1937)

* Migrate responsibleai tests to use utilities in rai_test_utils - Part 1

Signed-off-by: Gaurav Gupta <[email protected]>

* Add create_cancer_data

Signed-off-by: Gaurav Gupta <[email protected]>

* fix

Signed-off-by: Gaurav Gupta <[email protected]>

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Roman Lutz <[email protected]>

* Fix bubble chart render issue due to exception in `SidePanel` (#1941)

Signed-off-by: Gaurav Gupta <[email protected]>

* fixing strings (#1943)

* Dataset explorer: Propagate number of bins to SDK backend API (#1940)

* Dataset explorer: Propagate number of bins to SDK backend API

Signed-off-by: Gaurav Gupta <[email protected]>

* Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts

Co-authored-by: Roman Lutz <[email protected]>

* Revert "Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts"

This reverts commit a8b2e42.

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Roman Lutz <[email protected]>

* Add tests

Signed-off-by: Gaurav Gupta <[email protected]>

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Roman Lutz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants