[Accessibility] Data analysis scatter chart - use symbol and color to differentiate data series #1667

RubyZ10 · 2022-08-24T22:37:12Z

This PR made change to Data analysis scatter chart, before this change, we use 13 colors to differentiate different data series, but it does not work for people with vision issues.
With the change, we introduce five different symbols combine with three colors

Before change

After change

Dark theme

Dark theme with two data series

Description

Checklist

I have added screenshots above for all UI changes.
I have added e2e tests for all UI changes.
Documentation was updated if it was needed.

Signed-off-by: Ruby Zhu <[email protected]>

…sible-ai-toolbox into zhenzhu/a11yFix

Signed-off-by: Ruby Zhu <[email protected]>

codecov-commenter · 2022-08-24T22:41:28Z

Codecov Report

Merging #1667 (6fcb55f) into main (f2c5bab) will decrease coverage by 3.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   88.88%   85.31%   -3.58%     
==========================================
  Files         105       58      -47     
  Lines        5553     3031    -2522     
==========================================
- Hits         4936     2586    -2350     
+ Misses        617      445     -172

Flag	Coverage Δ
unittests	`85.31% <ø> (-3.58%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...leai/responsibleai/databalanceanalysis/__init__.py
...eai/responsibleai/managers/data_balance_manager.py
...ai/responsibleai/_tools/causal/causal_constants.py
...ponsibleai/responsibleai/rai_insights/constants.py
...sibleai/responsibleai/rai_insights/rai_insights.py
responsibleai/responsibleai/__version__.py
...ai/databalanceanalysis/feature_balance_measures.py
responsibleai/responsibleai/_data_validations.py
...bleai/responsibleai/_tools/causal/causal_config.py
...onsibleai/responsibleai/managers/causal_manager.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ruby Zhu <[email protected]>

…sible-ai-toolbox into zhenzhu/a11yFix

github-actions · 2022-08-24T23:21:20Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

libs/core-ui/src/lib/components/InteractiveLegend.styles.ts

libs/core-ui/src/lib/components/InteractiveLegend.tsx

libs/dataset-explorer/src/lib/ScatterUtils.ts

libs/core-ui/src/lib/components/InteractiveLegend.tsx

github-actions · 2022-08-24T23:24:17Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

github-actions · 2022-08-24T23:42:57Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

Signed-off-by: Ruby Zhu <[email protected]>

github-actions · 2022-08-25T01:00:05Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

github-actions · 2022-08-25T01:14:23Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

libs/core-ui/src/lib/components/InteractiveLegendUtils.test.ts

imatiach-msft

Approved but the most important thing is to make sure colors are consistent and you are using the global FluentUI paletter we have in core-ui. This was a task given to me and we need to make sure we continue to use consistent colors throughout the application's components.

libs/core-ui/src/lib/components/InteractiveLegendUtils.ts

libs/dataset-explorer/src/lib/ScatterUtils.ts

imatiach-msft · 2022-08-25T14:13:27Z

On the colors, please see this PR for more details:
#1559
I think we should either change the current PR's colors to be consistent with that or change the global color palette to use these colors.

Signed-off-by: Ruby Zhu <[email protected]>

github-actions · 2022-08-25T18:50:05Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

github-actions · 2022-08-25T19:02:22Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

Signed-off-by: Ruby Zhu <[email protected]>

…sible-ai-toolbox into zhenzhu/a11yFix

github-actions · 2022-08-25T20:31:41Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

Signed-off-by: Ruby Zhu <[email protected]>

github-actions · 2022-08-26T01:35:15Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

github-actions · 2022-08-26T01:38:40Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

Signed-off-by: Ruby Zhu <[email protected]>

…sible-ai-toolbox into zhenzhu/a11yFix

github-actions · 2022-08-26T19:22:20Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

github-actions · 2022-08-26T19:26:06Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

Signed-off-by: Ruby Zhu <[email protected]>

…sible-ai-toolbox into zhenzhu/a11yFix

github-actions · 2022-08-27T05:53:24Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

Signed-off-by: Ruby Zhu <[email protected]>

github-actions · 2022-08-29T17:42:58Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

github-actions · 2022-08-29T17:43:39Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/a11yFix/dashboard/index.html

RubyZ10 and others added 6 commits August 22, 2022 16:53

error analysis screen reader

5b2ecb0

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'main' into zhenzhu/a11yFix

277e313

fix lint

b1ad7f6

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'zhenzhu/a11yFix' of https://github.com/microsoft/respon…

0892df5

…sible-ai-toolbox into zhenzhu/a11yFix

scatter chart

0f9676a

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'main' into zhenzhu/a11yFix

b68164a

RubyZ10 added 2 commits August 24, 2022 15:56

lint fix

a9761ee

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'zhenzhu/a11yFix' of https://github.com/microsoft/respon…

a360410

…sible-ai-toolbox into zhenzhu/a11yFix

RubyZ10 marked this pull request as ready for review August 24, 2022 22:56

RubyZ10 requested review from imatiach-msft, tongyu-microsoft, xuke444, vinuthakaranth and romanlutz as code owners August 24, 2022 22:56

gaugup requested changes Aug 24, 2022

View reviewed changes

RubyZ10 added 2 commits August 24, 2022 17:12

add unit test

2700898

Signed-off-by: Ruby Zhu <[email protected]>

update test file name

261da1e

Signed-off-by: Ruby Zhu <[email protected]>

imatiach-msft reviewed Aug 25, 2022

View reviewed changes

libs/core-ui/src/lib/components/InteractiveLegendUtils.test.ts Show resolved Hide resolved

imatiach-msft reviewed Aug 25, 2022

View reviewed changes

libs/core-ui/src/lib/components/InteractiveLegendUtils.test.ts Outdated Show resolved Hide resolved

imatiach-msft approved these changes Aug 25, 2022

View reviewed changes

libs/core-ui/src/lib/components/InteractiveLegendUtils.ts Outdated Show resolved Hide resolved

libs/dataset-explorer/src/lib/ScatterUtils.ts Outdated Show resolved Hide resolved

RubyZ10 and others added 3 commits August 25, 2022 10:15

fix unit test lint and switch case

04ba3b7

Signed-off-by: Ruby Zhu <[email protected]>

update color

6435bc4

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'main' into zhenzhu/a11yFix

dcc9912

RubyZ10 added 2 commits August 25, 2022 12:48

lint

df7b5c4

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'zhenzhu/a11yFix' of https://github.com/microsoft/respon…

0072646

…sible-ai-toolbox into zhenzhu/a11yFix

gaugup approved these changes Aug 25, 2022

View reviewed changes

RubyZ10 enabled auto-merge (squash) August 25, 2022 20:42

vinuthakaranth approved these changes Aug 26, 2022

View reviewed changes

RubyZ10 and others added 2 commits August 25, 2022 17:41

fix e2e

b55643a

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'main' into zhenzhu/a11yFix

3c855e9

RubyZ10 and others added 3 commits August 26, 2022 11:22

fix lint

5892190

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'zhenzhu/a11yFix' of https://github.com/microsoft/respon…

2173c78

…sible-ai-toolbox into zhenzhu/a11yFix

Merge branch 'main' into zhenzhu/a11yFix

b6c82d3

RubyZ10 disabled auto-merge August 26, 2022 18:25

vinuthakaranth approved these changes Aug 26, 2022

View reviewed changes

RubyZ10 enabled auto-merge (squash) August 26, 2022 19:06

RubyZ10 added 2 commits August 26, 2022 22:09

fix e2e

e41ba62

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'zhenzhu/a11yFix' of https://github.com/microsoft/respon…

3086b8d

…sible-ai-toolbox into zhenzhu/a11yFix

RubyZ10 and others added 2 commits August 29, 2022 09:57

remove debugger

77b0cfa

Signed-off-by: Ruby Zhu <[email protected]>

Merge branch 'main' into zhenzhu/a11yFix

6fcb55f

RubyZ10 merged commit cb46dc3 into main Aug 29, 2022

RubyZ10 deleted the zhenzhu/a11yFix branch August 29, 2022 18:49

imatiach-msft mentioned this pull request Sep 12, 2022

release raiwidgets and responsibleai 0.22.0 #1707

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Accessibility] Data analysis scatter chart - use symbol and color to differentiate data series #1667

[Accessibility] Data analysis scatter chart - use symbol and color to differentiate data series #1667

RubyZ10 commented Aug 24, 2022 •

edited

Loading

codecov-commenter commented Aug 24, 2022 •

edited

Loading

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

imatiach-msft left a comment

imatiach-msft commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 27, 2022

github-actions bot commented Aug 29, 2022

github-actions bot commented Aug 29, 2022

[Accessibility] Data analysis scatter chart - use symbol and color to differentiate data series #1667

[Accessibility] Data analysis scatter chart - use symbol and color to differentiate data series #1667

Conversation

RubyZ10 commented Aug 24, 2022 • edited Loading

Description

Checklist

codecov-commenter commented Aug 24, 2022 • edited Loading

Codecov Report

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

imatiach-msft left a comment

Choose a reason for hiding this comment

imatiach-msft commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 26, 2022

github-actions bot commented Aug 27, 2022

github-actions bot commented Aug 29, 2022

github-actions bot commented Aug 29, 2022

RubyZ10 commented Aug 24, 2022 •

edited

Loading

codecov-commenter commented Aug 24, 2022 •

edited

Loading