Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralize plot colors to core ui #1559

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

imatiach-msft
Copy link
Contributor

Description

Centralize all chart/plot colors to core ui package.

  • Use consistent colors across all charts
  • Removed duplicate color definitions
  • Rename fabric variables to fluentui

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/centralize-plot-colors branch 2 times, most recently from a0f18fe to ac142fd Compare July 14, 2022 15:38
2 similar comments
@imatiach-msft imatiach-msft force-pushed the ilmat/centralize-plot-colors branch from ac142fd to b9833cd Compare July 18, 2022 13:19
@imatiach-msft imatiach-msft requested a review from RubyZ10 as a code owner July 18, 2022 13:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #1559 (f645fb2) into main (f645fb2) will not change coverage.
The diff coverage is n/a.

❗ Current head f645fb2 differs from pull request most recent head b9833cd. Consider uploading reports for the commit b9833cd to get more accurate results

@@           Coverage Diff           @@
##             main    #1559   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         109      109           
  Lines        5271     5271           
=======================================
  Hits         4638     4638           
  Misses        633      633           
Flag Coverage Δ
unittests 87.99% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f645fb2...b9833cd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move colors to central place for all plots
3 participants