Skip to content

fix(JavaScriptBundleLoader): PCLStorage does not work for this #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthargett merged 1 commit into from
Nov 1, 2016
Merged

fix(JavaScriptBundleLoader): PCLStorage does not work for this #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ReactWindows/ReactNative.Shared/Bridge/JavaScriptBundleLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
using PCLStorage;
using System;
using System.Threading.Tasks;
#if !WINDOWS_UWP
#if WINDOWS_UWP
using Windows.Storage;
#else
using System.IO;
using System.Reflection;
#endif
Expand Down Expand Up @@ -91,7 +93,7 @@ public override async Task InitializeAsync()
try
{
#if WINDOWS_UWP
var storageFile = await FileSystem.Current.GetFileFromPathAsync(new Uri(SourceUrl).ToString()).ConfigureAwait(false);
var storageFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri(SourceUrl)).AsTask().ConfigureAwait(false);
_script = storageFile.Path;
#else
var assembly = Assembly.GetAssembly(typeof(JavaScriptBundleLoader));
Expand Down
2 changes: 2 additions & 0 deletions ReactWindows/ReactNative.Shared/CoreModulesPackage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
using ReactNative.UIManager.Events;
using System;
using System.Collections.Generic;
#if !WINDOWS_UWP
using System.Windows;
#endif

namespace ReactNative
{
Expand Down