fix(JavaScriptBundleLoader): PCLStorage does not work for this#848
Merged
matthargett merged 1 commit intomicrosoft:masterfrom Nov 1, 2016
Merged
fix(JavaScriptBundleLoader): PCLStorage does not work for this#848matthargett merged 1 commit intomicrosoft:masterfrom
matthargett merged 1 commit intomicrosoft:masterfrom
Conversation
rozele
commented
Nov 1, 2016
| { | ||
| #if WINDOWS_UWP | ||
| var storageFile = await FileSystem.Current.GetFileFromPathAsync(new Uri(SourceUrl).ToString()).ConfigureAwait(false); | ||
| var storageFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri(SourceUrl)); |
Contributor
Author
There was a problem hiding this comment.
Don't forget configureAwait
Apparently PCLStorage fails to resolve the ms-appx:/// URIs. So, let's not use that. cc @matthargett
matthargett
approved these changes
Nov 1, 2016
Contributor
matthargett
left a comment
matthargett
left a comment
There was a problem hiding this comment.
yup, PCLStorage doesn't have a replacement for GetFileFromApplicationUriAsync. This was set up correctly in another diff, but it looks like things got mixed up at some point.
rozele
added a commit
that referenced
this pull request
Nov 10, 2016
PCLStorage fails to resolve the ms-appx:/// URIs. Revert to UWP-specific code block.
rozele
added a commit
that referenced
this pull request
Jun 21, 2019
Summary: Specifically, updates the UWP .vcxproj for MSBuild and also exposes the UseLegacyStretchBehaviour API for use with react-native-windows. Pull Request resolved: facebook/yoga#848 Reviewed By: SidharthGuglani Differential Revision: D13848609 Pulled By: davidaurelio fbshipit-source-id: eab046ff3c47e49706f515e209d8aaf750c2198f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently PCLStorage fails to resolve the ms-appx:/// URIs. So, let's not use that.
cc @matthargett