[0.61] Cherry-pick PR #4893 for tab-focus bug #4703 #5199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft#4893) * Change files * revert dfc57fc * set default tab index to -1, the hope is to be in line with xbox assumption * xbox doesn't seem to rely on this, changing default back to match xaml default
ghost
added
the
acoates-ms
changed the title
Contributor
Author
|
The CI loop is failing due to out-of-memory. This is unrelated to the change, I will force it in if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4703
This fixes a regression that came in with this change:
#4180
this change introduced a convention that setting tabIndex = -1 makes the control no longer tab focusable. This stomps over the behavior of the acceptsKeyboardFocus prop, making it not work correctly anymore.
This fix reverts that behavior. To achieve this behavior, customers should set acceptsKeyboarFocus = false. Note that this property will become deprecated and replaced by focusable.
Microsoft Reviewers: Open in CodeFlow