-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Modal outstanding issues #15445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Modal outstanding issues #15445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n title bar with no icon
protikbiswas100
approved these changes
Dec 5, 2025
Contributor
protikbiswas100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vineethkuttan
approved these changes
Dec 5, 2025
iamAbhi-916
added a commit
to iamAbhi-916/react-native-windows
that referenced
this pull request
Dec 5, 2025
* solve modal foreground/background issue and only have a closebutton on title bar with no icon * Change files
iamAbhi-916
added a commit
to iamAbhi-916/react-native-windows
that referenced
this pull request
Dec 5, 2025
* solve modal foreground/background issue and only have a closebutton on title bar with no icon * Change files
iamAbhi-916
added a commit
to iamAbhi-916/react-native-windows
that referenced
this pull request
Dec 5, 2025
* solve modal foreground/background issue and only have a closebutton on title bar with no icon * Change files
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1> On closing modal the focus should go back to the main wndproc along with the system event message pump.
2> Modal title bar should only have Close( X ) button.
3> Modal title bar shouldn't have default application icon.
Type of Change
Why
Solves the UI/UX related problems with RNW modal
Resolves [Add Relevant Issue Here]
#15443
#15444
What
setforeground and setfocus for main window after closure of modal
remove icon from App window
disable minimize and maximize option for modal
Screenshots
modal_revamp.mp4
Testing
tested in playground
Changelog
Should this change be included in the release notes: _indicate yes
Add a brief summary of the change to use in the release notes for the next release.
Fixed focus restoration on close, removed minimize/maximize buttons, and hidden title bar icon for cleaner modal appearance.
Microsoft Reviewers: Open in CodeFlow