Update telemetry test to use localId instead of deviceId for consistency #15144
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2025 16:40
jonthysell
requested changes
Sep 16, 2025
change/@react-native-windows-telemetry-e8822c8e-55c2-4622-b9ef-48a80761ca6a.json
Outdated
Show resolved
Hide resolved
change/@react-native-windows-telemetry-e8822c8e-55c2-4622-b9ef-48a80761ca6a.json
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
…-48a80761ca6a.json Co-authored-by: Jon Thysell <[email protected]>
…-48a80761ca6a.json Co-authored-by: Jon Thysell <[email protected]>
…thub.com/HariniMalothu17/react-native-windows into user/harinimalothu/FixToRetrieveDeviceId
Co-authored-by: Jon Thysell <[email protected]>
|
@jonthysell I have resolved all your comments.Please review |
jonthysell
approved these changes
Sep 17, 2025
jonthysell
reviewed
Sep 18, 2025
packages/@react-native-windows/telemetry/src/e2etest/telemetry.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed telemetry property key from
deviceIdtolocalIdto align with telemetry transmission naming conventions.localId(inenvelope.ext.device.localId)localIdas the property key creates consistency between storage and transmission namingType of Change
Why
Our telemetry was populating device identifier as
deviceIdext.device.localIdto be populatedlocalIdfield prevented Collector from properly inferringdevice.idResolves #15192
What
Changed telemetry test property key from
deviceIdtolocalIdto align with telemetry transmission naming conventions.Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
Changelog
Should this change be included in the release notes: no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow