Skip to content

Conversation

@iamAbhi-916
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 commented Apr 10, 2025

Description

Draft : Updated release.yaml to follow Release Pipelines in 1ES PT

Followed : https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/releasepipelines/overview?tabs=productionjobvalidation

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.

Resolves [Add Relevant Issue Here]
#14464

What

Added fields to

 templateContext:
    type: releaseJob
    isProduction: true

Screenshots

Add any relevant screen captures here from before or after your changes.

Testing

If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.

Changelog

no

Add a brief summary of the change to use in the release notes for the next release.

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 requested review from a team as code owners April 10, 2025 17:59
Copy link
Contributor

@jonthysell jonthysell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold off on this: I don't know yet the full impact of changing the type here, we can't test these changes in PR, and any breakage will prevent releasing new daily builds. This kind of change will require active monitoring, usually takes multiple attempts to get everything working, and needs to be timed in a way that doesn't disrupt regular work in the repo.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Apr 10, 2025
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants