Bump minimum VS version to 17.11.0 #13455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This won't pass until the VM image refresh completes, but that will be a good test that the PR fails when it detects the current VM image doesn't have the right VS version. |
marlenecota
approved these changes
Jul 16, 2024
|
Tried to bump us to 17.10.4, but it looks like it breaks our native unit tests: https://developercommunity.visualstudio.com/t/VS2022-17101-throws-an-error-in-Azure-/10678969 So end users should be unblocked by 17.10.4, but we can't update the repo until maybe 17.10.5. |
jonthysell
changed the title
|
Tried to bump to 10.17.5, but now DeployAppRecipe is broken again. |
jonthysell
changed the title
microsoft-github-policy-service
bot
added
the
New Architecture
|
Updating this PR to require the just released 17.11.0. Waiting for the test image to refresh so I can validate everything's clear, then I'll update the main image. |
jonthysell
added
Developer First Experience
microsoft-github-policy-service
bot
added
the
New Architecture
This was referenced Aug 15, 2024
This reverts commit a56d2a0.
marlenecota
approved these changes
Aug 15, 2024
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Aug 16, 2024
This PR backports microsoft#13455 to 0.75. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves microsoft#13339 Resolves microsoft#13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Aug 16, 2024
This PR backports microsoft#13455 to 0.74. This PR bumps the minimum version of VS that RNW expects to 17.11.0. - Bug fix (non-breaking change which fixes an issue) To make sure users don't use the regressed builds of VS 2022. Resolves microsoft#13339 Resolves microsoft#13374 Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. N/A `run-windows` now works with 17.11.0. Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Aug 16, 2024
This PR backports microsoft#13455 to 0.74. This PR bumps the minimum version of VS that RNW expects to 17.11.0. - Bug fix (non-breaking change which fixes an issue) To make sure users don't use the regressed builds of VS 2022. Resolves microsoft#13339 Resolves microsoft#13374 Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. N/A `run-windows` now works with 17.11.0. Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Aug 16, 2024
This PR backports microsoft#13455 to 0.73. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves microsoft#13339 Resolves microsoft#13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Aug 16, 2024
This PR backports microsoft#13455 to 0.72. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves microsoft#13339 Resolves microsoft#13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
that referenced
this pull request
Aug 16, 2024
This PR backports #13455 to 0.75. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves #13339 Resolves #13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
that referenced
this pull request
Aug 16, 2024
This PR backports #13455 to 0.73. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves #13339 Resolves #13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
that referenced
this pull request
Aug 16, 2024
This PR backports #13455 to 0.74. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves #13339 Resolves #13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
jonthysell
added a commit
that referenced
this pull request
Aug 20, 2024
This PR backports #13455 to 0.72. ## Description This PR bumps the minimum version of VS that RNW expects to 17.11.0. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To make sure users don't use the regressed builds of VS 2022. Resolves #13339 Resolves #13374 ### What Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4. ## Screenshots N/A ## Testing `run-windows` now works with 17.11.0. ## Changelog Should this change be included in the release notes: _yes_ Require Visual Studio 2022 >= v17.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the minimum version of VS that RNW expects to 17.11.0.
Type of Change
Why
To make sure users don't use the regressed builds of VS 2022.
Resolves #13339
Resolves #13374
What
Bumped VS version checks for
run-windowsandrnw-dependencies.ps1. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.Screenshots
N/A
Testing
run-windowsnow works with 17.11.0.Changelog
Should this change be included in the release notes: yes
Require Visual Studio 2022 >= v17.11.0
Microsoft Reviewers: Open in CodeFlow