Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build e2e-test-app-fabric with VS 2022 Preview 17.11 #13374

Closed
jonthysell opened this issue Jun 20, 2024 · 1 comment · Fixed by #13455
Closed

Unable to build e2e-test-app-fabric with VS 2022 Preview 17.11 #13374

jonthysell opened this issue Jun 20, 2024 · 1 comment · Fixed by #13455
Assignees
@jonthysell
Labels
bug External Developer Tooling Issue caused by the tool chain, not by RNW itself New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Scenario: Visual Studio
Milestone
Next

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Jun 20, 2024 •
edited
Loading

Problem Description

In verifying that the current VS preview build, 17.11, fixes issue #13339, I hit this error when trying to build e2e-test-app-fabric:

 × Build failed with message 9:8>E:\code\rnw\vnext\Microsoft.ReactNative\Fabric\Composition\CompositionContextHelper.cpp(1335,71): error C2275: 'Microsoft::ReactNative::Composition::Experimental::CompositionTypeTraits<Microsoft::ReactNative::Composition::Experimental::MicrosoftTypeTag>::CompositionColorBrush': expected an expression instead of a type [E:\code\rnw\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]. Check your build configuration.
 i Gathering MSBuild data for telemetry.
 i Unable to find msbuildproperties.g.json
Command failed with error MSBuildError: 9:8>E:\code\rnw\vnext\Microsoft.ReactNative\Fabric\Composition\CompositionContextHelper.cpp(1335,71): error C2275: 'Microsoft::ReactNative::Composition::Experimental::CompositionTypeTraits<Microsoft::ReactNative::Composition::Experimental::MicrosoftTypeTag>::CompositionColorBrush': expected an expression instead of a type [E:\code\rnw\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]

Steps To Reproduce

  1. Clone RNW repo
  2. Install VS 2022 Preview (17.11)
  3. Make sure run-windows uses 17.11 (see Added MinimumVisualStudioVersion env variable to force run-windows to use a particular version of VS installed #13373)
  4. In packages/e2e-test-app-fabric, run yarn windows --release --logging

Expected Results

App builds and launches.

CLI version

14.0.0-alpha.2

Environment

info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.26100
  CPU: "(24) x64 AMD Ryzen Threadripper PRO 3945WX 12-Cores     "
  Memory: 52.51 GB / 63.86 GB
Binaries:
  Node:
    version: 18.18.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.8.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.22621.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.11.35017.193 (Visual Studio Enterprise 2022)
    - 17.10.35013.160 (Visual Studio Enterprise 2022)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Community Modules

No response

Target Platform Version

None

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Release

Snack, code example, screenshot, or link to a repository

msbuild.binlog.zip
@jonthysell jonthysell added the bug label Jun 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 20, 2024
@jonthysell jonthysell added Scenario: Visual Studio New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric labels Jun 20, 2024
@jonthysell jonthysell mentioned this issue Jun 20, 2024
Closed
@chrisglein chrisglein added the External Developer Tooling Issue caused by the tool chain, not by RNW itself label Jun 24, 2024
@chrisglein chrisglein added this to the Next milestone Jun 24, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 24, 2024
@jonthysell jonthysell self-assigned this Aug 14, 2024
@jonthysell jonthysell mentioned this issue Aug 14, 2024
Merged
@jonthysell
Copy link
Contributor Author

I have confirmed that 17.11.0 fixes this issue (and other outstanding VS issues) for us. I'm updating our CI images to 17.11.0 now and PR #13455 will bump our dependency script to make sure you have 17.11.0 installed, but everyone should be safe to upgrade to 17.11.0 now. Sorry that this took so long to figure out.

jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Aug 16, 2024
@jonthysell
[0.75] Bump minimum VS version to 17.11.0
0b4088b 
This PR backports microsoft#13455 to 0.75.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves microsoft#13339
Resolves microsoft#13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
@jonthysell jonthysell mentioned this issue Aug 16, 2024
Merged
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Aug 16, 2024
@jonthysell
[0.74] Bump minimum VS version to 17.11.0
5bd6f9d 
This PR backports microsoft#13455 to 0.74.

This PR bumps the minimum version of VS that RNW expects to 17.11.0.
- Bug fix (non-breaking change which fixes an issue)
To make sure users don't use the regressed builds of VS 2022.

Resolves microsoft#13339
Resolves microsoft#13374
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.
N/A
`run-windows` now works with 17.11.0.
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
@jonthysell jonthysell mentioned this issue Aug 16, 2024
Merged
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Aug 16, 2024
@jonthysell
[0.74] Bump minimum VS version to 17.11.0
6e84539 
This PR backports microsoft#13455 to 0.74.

This PR bumps the minimum version of VS that RNW expects to 17.11.0.
- Bug fix (non-breaking change which fixes an issue)
To make sure users don't use the regressed builds of VS 2022.

Resolves microsoft#13339
Resolves microsoft#13374
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.
N/A
`run-windows` now works with 17.11.0.
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Aug 16, 2024
@jonthysell
[0.73] Bump minimum VS version to 17.11.0
be553e6 
This PR backports microsoft#13455 to 0.73.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves microsoft#13339
Resolves microsoft#13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
@jonthysell jonthysell mentioned this issue Aug 16, 2024
Merged
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Aug 16, 2024
@jonthysell
[0.72] Bump minimum VS version to 17.11.0
ba8e7b8 
This PR backports microsoft#13455 to 0.72.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves microsoft#13339
Resolves microsoft#13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
@jonthysell jonthysell mentioned this issue Aug 16, 2024
Merged
jonthysell added a commit that referenced this issue Aug 16, 2024
@jonthysell
[0.75] Bump minimum VS version to 17.11.0 (#13582)
80cd62f 
This PR backports #13455 to 0.75.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves #13339
Resolves #13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
jonthysell added a commit that referenced this issue Aug 16, 2024
@jonthysell
[0.73] Bump minimum VS version to 17.11.0 (#13584)
536e013 
This PR backports #13455 to 0.73.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves #13339
Resolves #13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
jonthysell added a commit that referenced this issue Aug 16, 2024
@jonthysell
[0.74] Bump minimum VS version to 17.11.0 (#13583)
468cc10 
This PR backports #13455 to 0.74.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves #13339
Resolves #13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
jonthysell added a commit that referenced this issue Aug 20, 2024
@jonthysell
[0.72] Bump minimum VS version to 17.11.0 (#13585)
becc1d3 
This PR backports #13455 to 0.72.

## Description

This PR bumps the minimum version of VS that RNW expects to 17.11.0.

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
To make sure users don't use the regressed builds of VS 2022.

Resolves #13339
Resolves #13374

### What
Bumped VS version checks for `run-windows` and `rnw-dependencies.ps1`. Updated ADO image to reflect updated images are no longer locked to VS v17.9.4.

## Screenshots
N/A

## Testing
`run-windows` now works with 17.11.0.

## Changelog
Should this change be included in the release notes: _yes_

Require Visual Studio 2022 >= v17.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonthysell jonthysell

Labels
bug External Developer Tooling Issue caused by the tool chain, not by RNW itself New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Scenario: Visual Studio
Projects
RNW New Architecture
Status: Done
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Bump minimum VS version to 17.11.0 jonthysell/react-native-windows
2 participants
@jonthysell @chrisglein