Skip to content

Modal outstanding issues and update newArch Gallery to 0.81.0-preview.8 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 5 commits into from
Dec 10, 2025
Merged

Modal outstanding issues and update newArch Gallery to 0.81.0-preview.8 #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af6d856
remove extra close on modal UI
iamAbhi-916 Dec 9, 2025
6875b86
update gallery to 0.81.0-preview.8 RNW
iamAbhi-916 Dec 9, 2025
bf0ebdd
fix modal css
iamAbhi-916 Dec 9, 2025
17ef021
remove pressable import
iamAbhi-916 Dec 9, 2025
ac85b59
update package app manifest
iamAbhi-916 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NewArch/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"@react-native-clipboard/clipboard": "^1.16.1",
"lowlight": "^1.17.0",
"react": "19.1.0",
"react-native": "0.81.0-nightly-20250709-6892dde36",
"react-native-windows": "0.81.0-preview.6"
"react-native": "0.81.0",
"react-native-windows": "0.81.0-preview.8"
},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
42 changes: 24 additions & 18 deletions NewArch/src/examples/ModalExamplePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
import {Button, View, Text, StyleSheet, Dimensions, PlatformColor, AccessibilityInfo, Pressable} from 'react-native';
import {Button, View, Text, StyleSheet, Dimensions, PlatformColor, AccessibilityInfo} from 'react-native';
import {Modal} from 'react-native-windows'
import React from 'react';
import {Example} from '../components/Example';
Expand Down Expand Up @@ -128,13 +128,6 @@ export const ModalExamplePage: React.FunctionComponent<{navigation?: any}> = ({n
onAccessibilityTap={changeModal1}/>
<Modal visible={modal1} onRequestClose={changeModal1}>
<View style={styles.simpleModalView}>
<Pressable
style={styles.closeButton}
onPress={changeModal1}
accessibilityRole="button"
accessibilityLabel="Close Modal">
<Text style={styles.closeButtonText}>×</Text>
</Pressable>
<Text style={styles.simpleModalText}>This is a simple Modal</Text>
<Button
color={'#8D8383'}
Expand Down Expand Up @@ -192,19 +185,13 @@ export const ModalExamplePage: React.FunctionComponent<{navigation?: any}> = ({n
setOnShowCount(onShowCount + 1);
}}>
<View style={styles.eventsModalView}>
<Pressable
style={styles.closeButton}
onPress={changeModal3}
accessibilityRole="button"
accessibilityLabel="Close Modal">
<Text style={styles.closeButtonText}>×</Text>
</Pressable>
<View style={styles.container}>
<Text style={{fontWeight: 'bold'}}>Modal Events</Text>
<Text>onShow event Count = {onShowCount}</Text>
<Text>onDismiss event Count = {onDismissCount}</Text>
<Text style={styles.modalTextBold}>Modal Events</Text>
<Text style={styles.modalText}>onShow event Count = {onShowCount}</Text>
<Text style={styles.modalText}>onDismiss event Count = {onDismissCount}</Text>
</View>
<Button
color={'#8D8383'}
ref={modal3FirstButtonRef}
title="Close Modal"
accessibilityLabel="Close Modal"
Expand Down Expand Up @@ -263,9 +250,12 @@ const styles = StyleSheet.create({
},
simpleModalView: {
width: 500,
height: 200,
borderRadius: 10,
padding: 15,
alignItems: 'center',
justifyContent: 'center',
backgroundColor: 'white',
shadowOffset: {
width: 0,
height: 2,
Expand All @@ -278,4 +268,20 @@ const styles = StyleSheet.create({
color: 'black',
marginBottom: 20,
},
eventsModalView: {
width: 500,
height: 300,
borderRadius: 10,
padding: 15,
alignItems: 'center',
justifyContent: 'center',
backgroundColor: 'white',
},
modalText: {
color: 'black',
},
modalTextBold: {
color: 'black',
fontWeight: 'bold',
},
});
2 changes: 1 addition & 1 deletion NewArch/windows/NewArch.Package/Package.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<Identity
Name="Microsoft.ReactNativeGallery-Experimental"
Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
Version="2.0.8.0" />
Version="2.0.9.0" />

<Properties>
<DisplayName>React Native Gallery</DisplayName>
Expand Down
42 changes: 21 additions & 21 deletions NewArch/windows/NewArch/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
},
"Microsoft.ReactNative": {
"type": "Direct",
"requested": "[0.81.0-preview.6, )",
"resolved": "0.81.0-preview.6",
"contentHash": "/KumdWCD0bYXB1pgKylAyBMnTDtWDhy49ZaLxYT0tH2uniZJFPQJvWX9x8+Yqf58+WrrcXzYMJ6etJzxJ5KrVA=="
"requested": "[0.81.0-preview.8, )",
"resolved": "0.81.0-preview.8",
"contentHash": "BVUbSbBOrCo0BpL114YzYjfvIiHscgi514oLXPl/hSV3TfMfk/Ux3uR4WUSW2uhqBOpBwEQL4VOKJiFH4WX/EA=="
},
"Microsoft.ReactNative.Cxx": {
"type": "Direct",
"requested": "[0.81.0-preview.6, )",
"resolved": "0.81.0-preview.6",
"contentHash": "tAnpOr0sypxkpoDrMg7sWrxybH/IevFnB04e+AAmOptPdnICoiHXMtKnDX4YHZM+6l/ZgQ3fCrrNlkrFwtxmKA==",
"requested": "[0.81.0-preview.8, )",
"resolved": "0.81.0-preview.8",
"contentHash": "ZmMhB0E7KAKkqDd3+MNZcBentThYxLa+jmWDUA6H+nXjAniCW+Vx7wo4ZC3UXUIdEp9yUn5Jx6YJdyE6/5uDPw==",
"dependencies": {
"Microsoft.ReactNative": "0.81.0-preview.6"
"Microsoft.ReactNative": "0.81.0-preview.8"
}
},
"Microsoft.VCRTForwarders.140": {
Expand Down Expand Up @@ -64,8 +64,8 @@
"clipboard": {
"type": "Project",
"dependencies": {
"Microsoft.ReactNative": "[0.81.0-preview.6, )",
"Microsoft.ReactNative.Cxx": "[0.81.0-preview.6, )",
"Microsoft.ReactNative": "[0.81.0-preview.8, )",
"Microsoft.ReactNative.Cxx": "[0.81.0-preview.8, )",
"Microsoft.VCRTForwarders.140": "[1.0.2-rc, )",
"Microsoft.WindowsAppSDK": "[1.7.250401001, )",
"boost": "[1.83.0, )"
Expand All @@ -75,9 +75,9 @@
"native,Version=v0.0/win": {
"Microsoft.ReactNative": {
"type": "Direct",
"requested": "[0.81.0-preview.6, )",
"resolved": "0.81.0-preview.6",
"contentHash": "/KumdWCD0bYXB1pgKylAyBMnTDtWDhy49ZaLxYT0tH2uniZJFPQJvWX9x8+Yqf58+WrrcXzYMJ6etJzxJ5KrVA=="
"requested": "[0.81.0-preview.8, )",
"resolved": "0.81.0-preview.8",
"contentHash": "BVUbSbBOrCo0BpL114YzYjfvIiHscgi514oLXPl/hSV3TfMfk/Ux3uR4WUSW2uhqBOpBwEQL4VOKJiFH4WX/EA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Direct",
Expand All @@ -104,9 +104,9 @@
"native,Version=v0.0/win-arm64": {
"Microsoft.ReactNative": {
"type": "Direct",
"requested": "[0.81.0-preview.6, )",
"resolved": "0.81.0-preview.6",
"contentHash": "/KumdWCD0bYXB1pgKylAyBMnTDtWDhy49ZaLxYT0tH2uniZJFPQJvWX9x8+Yqf58+WrrcXzYMJ6etJzxJ5KrVA=="
"requested": "[0.81.0-preview.8, )",
"resolved": "0.81.0-preview.8",
"contentHash": "BVUbSbBOrCo0BpL114YzYjfvIiHscgi514oLXPl/hSV3TfMfk/Ux3uR4WUSW2uhqBOpBwEQL4VOKJiFH4WX/EA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Direct",
Expand All @@ -133,9 +133,9 @@
"native,Version=v0.0/win-x64": {
"Microsoft.ReactNative": {
"type": "Direct",
"requested": "[0.81.0-preview.6, )",
"resolved": "0.81.0-preview.6",
"contentHash": "/KumdWCD0bYXB1pgKylAyBMnTDtWDhy49ZaLxYT0tH2uniZJFPQJvWX9x8+Yqf58+WrrcXzYMJ6etJzxJ5KrVA=="
"requested": "[0.81.0-preview.8, )",
"resolved": "0.81.0-preview.8",
"contentHash": "BVUbSbBOrCo0BpL114YzYjfvIiHscgi514oLXPl/hSV3TfMfk/Ux3uR4WUSW2uhqBOpBwEQL4VOKJiFH4WX/EA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Direct",
Expand All @@ -162,9 +162,9 @@
"native,Version=v0.0/win-x86": {
"Microsoft.ReactNative": {
"type": "Direct",
"requested": "[0.81.0-preview.6, )",
"resolved": "0.81.0-preview.6",
"contentHash": "/KumdWCD0bYXB1pgKylAyBMnTDtWDhy49ZaLxYT0tH2uniZJFPQJvWX9x8+Yqf58+WrrcXzYMJ6etJzxJ5KrVA=="
"requested": "[0.81.0-preview.8, )",
"resolved": "0.81.0-preview.8",
"contentHash": "BVUbSbBOrCo0BpL114YzYjfvIiHscgi514oLXPl/hSV3TfMfk/Ux3uR4WUSW2uhqBOpBwEQL4VOKJiFH4WX/EA=="
},
"Microsoft.VCRTForwarders.140": {
"type": "Direct",
Expand Down
Loading
Loading