Fix isFocusable for FocusList component #10378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riknoll
reviewed
Feb 11, 2025
| @@ -59,7 +59,7 @@ export const FocusList = (props: FocusListProps) => { | |||
|
|
|||
| const isFocusable = (e: HTMLElement) => { | |||
| return e.getAttribute("data-isfocusable") === "true" | |||
| && getComputedStyle(e).display !== "none"; | |||
| && !!e.offsetParent; | |||
There was a problem hiding this comment.
i think this should be an explicit check for null, 0 is a valid value here, right?
There was a problem hiding this comment.
Good catch, yes. Changed here 51196b7.
There was a problem hiding this comment.
On second look it returns a reference to an element rather than an offset value, but this change does no harm. Not the best property name in the world.
riknoll
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus appears to get stuck while using the keyboard to navigate the versions in the "Version History" feature when parent tree items are not expanded. See the point at which focus becomes stuck in the screenshot below:
The
isFocusablemethod checks the visibility of the sub-tree item using its computed display property, but this does not take into account that the item's parent div is hidden.This PR uses
offsetParentas an alternative approach to checking element visibility. In addition,findNextFocusableElementnow passes the optional isFocusable argument to itself when called recursively.The
getComputedStyleapproach is still used infindNextFocusableElementas a fallback, but perhaps not unreasonably so.@microbit-matt-hillsdon