Fix isFocusable for FocusList component (#10378)

* Fix isFocusable for FocusList component * Use explicit check for null
microsoft · Feb 12, 2025 · d43f4c8 · d43f4c8
1 parent 8074d0b
commit d43f4c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/react-common/components/controls/FocusList.tsx b/react-common/components/controls/FocusList.tsx
@@ -59,7 +59,7 @@ export const FocusList = (props: FocusListProps) => {
 
     const isFocusable = (e: HTMLElement) => {
         return e.getAttribute("data-isfocusable") === "true"
-            && getComputedStyle(e).display !== "none";
+            && e.offsetParent !== null;
     }
 
     const onKeyDown = (e: React.KeyboardEvent<HTMLElement>) => {

diff --git a/react-common/components/util.tsx b/react-common/components/util.tsx
@@ -111,7 +111,7 @@ export function findNextFocusableElement(elements: HTMLElement[], focusedIndex:
             index += increment;
         }
     }
-    return findNextFocusableElement(elements, focusedIndex, index, forward);
+    return findNextFocusableElement(elements, focusedIndex, index, forward, isFocusable);
 }
 
 export function isFocusable(e: HTMLElement) {