-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walkthrough for VSCode Web #284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enhanced save logic Co-authored-by: Ved Garbha <[email protected]>
Co-authored-by: Ved Garbha <[email protected]>
Co-authored-by: Ved Garbha <[email protected]>
* folder structure change * removed hardcoded guid Co-authored-by: Ved Garbha <[email protected]>
* added error handling for all parameters * added method to decode query parameters * removed unused constants * renamed customcss files to have .css extension Co-authored-by: Ashish Choudhary <[email protected]>
Co-authored-by: Ved Garbha <[email protected]>
* added fileSystem activation event for our scheme * changed the uri scheme Co-authored-by: Ashish Choudhary <[email protected]>
Co-authored-by: Ved Garbha <[email protected]>
* language code fix for file name * auth fix and default language code to blank Co-authored-by: Ved Garbha <[email protected]>
Co-authored-by: Ved Garbha <[email protected]>
* added init telemetry event * added methods for path and query parameter telemetry * renamed methods * added api telemetry events * added perf telemetry events Co-authored-by: Ashish Choudhary <[email protected]>
Co-authored-by: Ashish Choudhary <[email protected]>
* Custom Css editing enable on this VSCode extension * Update for filename and common utility changes * fix spacing * Resolve comments * update comment
* fixed fileName case in the import * added filter to check for valid save events Co-authored-by: Ashish Choudhary <[email protected]>
* ts files localization changes for web extension * unique keys for translation added * added tasks for vscodeweb localization files Co-authored-by: Ved Garbha <[email protected]>
Co-authored-by: Ved Garbha <[email protected]>
* site visibility dialog added Co-authored-by: Ved Garbha <[email protected]>
ashishchoudhary001
requested review from
davidjenni,
tehcrashxor and
tyaginidhi
September 8, 2022 18:20
tehcrashxor
reviewed
Sep 8, 2022
tehcrashxor
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walkthrough for VSCode Web:
This walkthrough only opens in Web and at the moment it is not available for the Desktop/Codespaces.
This is controlled by the attribute: "when": "isWeb && virtualWorkspace"