Localization fix for web extension #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishchoudhary001
added a commit
that referenced
this pull request
Sep 6, 2022
* fetch and save feature implemented * eslint issues fixed * fixed undefined file issue * fixed multi-file creation issue * fixed save logic * Open default file for editing in vscode editor * name and display name updated with preview tag * Remote Save Provider refactoring and enhancements (#236) * enhanced save logic Co-authored-by: Ved Garbha <[email protected]> * orgurl from studio update (#237) Co-authored-by: Ved Garbha <[email protected]> * portalfoldername change (#238) Co-authored-by: Ved Garbha <[email protected]> * Folder structure change for Power portals (#239) * folder structure change * removed hardcoded guid Co-authored-by: Ved Garbha <[email protected]> * Users/aschoud/error handling (#240) * added error handling for all parameters * added method to decode query parameters * removed unused constants * renamed customcss files to have .css extension Co-authored-by: Ashish Choudhary <[email protected]> * updated default site name and portal uri scheme (#241) Co-authored-by: Ved Garbha <[email protected]> * added fileSystem activation event for our scheme (#243) * added fileSystem activation event for our scheme * changed the uri scheme Co-authored-by: Ashish Choudhary <[email protected]> * string changes (#244) Co-authored-by: Ved Garbha <[email protected]> * Language code fix for file name (#246) * language code fix for file name * auth fix and default language code to blank Co-authored-by: Ved Garbha <[email protected]> * lint fixes (#245) Co-authored-by: Ved Garbha <[email protected]> * Users/aschoud/web extension telemetry (#247) * added init telemetry event * added methods for path and query parameter telemetry * renamed methods * added api telemetry events * added perf telemetry events Co-authored-by: Ashish Choudhary <[email protected]> * added the correct url for logging (#248) Co-authored-by: Ashish Choudhary <[email protected]> * Custom css file edit enable (#256) * Custom Css editing enable on this VSCode extension * Update for filename and common utility changes * fix spacing * Resolve comments * update comment * Bug fix for save error popup. (#267) * fixed fileName case in the import * added filter to check for valid save events Co-authored-by: Ashish Choudhary <[email protected]> * Localization changes for web extension (#251) * ts files localization changes for web extension * unique keys for translation added * added tasks for vscodeweb localization files Co-authored-by: Ved Garbha <[email protected]> * removing nls loader from webconfig (#274) Co-authored-by: Ved Garbha <[email protected]> * Site visibility dialog (#272) * site visibility dialog added Co-authored-by: Ved Garbha <[email protected]> * reverting formatting changes in gulpfile * removing preview from the extension name * reintroducing preview tags to test the webExtension before merging with main * removing the ui fcb for webExtension * reverting changes to package.json and package-lock.json * adding activation event for webExtension * adding preview tag for testing * removed unused strings * removing preview tag Co-authored-by: Ved Garbha <[email protected]> Co-authored-by: Ashish Choudhary <[email protected]> Co-authored-by: Ved Garbha <[email protected]> Co-authored-by: tyaginidhi <[email protected]>
ashishchoudhary001
added a commit
that referenced
this pull request
Sep 8, 2022
* fetch and save feature implemented * eslint issues fixed * fixed undefined file issue * fixed multi-file creation issue * fixed save logic * Open default file for editing in vscode editor * name and display name updated with preview tag * Remote Save Provider refactoring and enhancements (#236) * enhanced save logic Co-authored-by: Ved Garbha <[email protected]> * orgurl from studio update (#237) Co-authored-by: Ved Garbha <[email protected]> * portalfoldername change (#238) Co-authored-by: Ved Garbha <[email protected]> * Folder structure change for Power portals (#239) * folder structure change * removed hardcoded guid Co-authored-by: Ved Garbha <[email protected]> * Users/aschoud/error handling (#240) * added error handling for all parameters * added method to decode query parameters * removed unused constants * renamed customcss files to have .css extension Co-authored-by: Ashish Choudhary <[email protected]> * updated default site name and portal uri scheme (#241) Co-authored-by: Ved Garbha <[email protected]> * added fileSystem activation event for our scheme (#243) * added fileSystem activation event for our scheme * changed the uri scheme Co-authored-by: Ashish Choudhary <[email protected]> * string changes (#244) Co-authored-by: Ved Garbha <[email protected]> * Language code fix for file name (#246) * language code fix for file name * auth fix and default language code to blank Co-authored-by: Ved Garbha <[email protected]> * lint fixes (#245) Co-authored-by: Ved Garbha <[email protected]> * Users/aschoud/web extension telemetry (#247) * added init telemetry event * added methods for path and query parameter telemetry * renamed methods * added api telemetry events * added perf telemetry events Co-authored-by: Ashish Choudhary <[email protected]> * added the correct url for logging (#248) Co-authored-by: Ashish Choudhary <[email protected]> * added the samples workflow to the preview extension * Custom css file edit enable (#256) * Custom Css editing enable on this VSCode extension * Update for filename and common utility changes * fix spacing * Resolve comments * update comment * Bug fix for save error popup. (#267) * fixed fileName case in the import * added filter to check for valid save events Co-authored-by: Ashish Choudhary <[email protected]> * Localization changes for web extension (#251) * ts files localization changes for web extension * unique keys for translation added * added tasks for vscodeweb localization files Co-authored-by: Ved Garbha <[email protected]> * removing nls loader from webconfig (#274) Co-authored-by: Ved Garbha <[email protected]> * walkthrough changes * Site visibility dialog (#272) * site visibility dialog added Co-authored-by: Ved Garbha <[email protected]> * reverting formatting changes in gulpfile * removing preview from the extension name * added test commands for the walkthrough * added dummy links in the walkthrough * added command to focus the sidebar * added conditions to show walkthrough only for webExetnsion * added command for opening file explorer * fixed walkthrough advanced capability image * added localization strings for walkthrough * added localization genearted files * fixed walkthrough image path * resetting the package version * added defaultFileUri * removed unused strings * reverting package-lock.json changes * rearranged activation events * rearranged activation events Co-authored-by: Ved Garbha <[email protected]> Co-authored-by: Ashish Choudhary <[email protected]> Co-authored-by: Ved Garbha <[email protected]> Co-authored-by: tyaginidhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the current limitation of vscode.dev - localization of external string does not work in the web extension.
More details here: microsoft/vscode#82595
This feature is expected to be available in September 2022
Temporary fix is to avoid the web extension from breaking is to offload nls loader from webconfig
Requirements: https://github.com/microsoft/vscode-dev/issues/477
Testing: