chore(bidi): use firefox browser type with moz-firefox- channel #37696

yury-s · 2025-10-02T23:14:02Z

Reference #37277

yury-s · 2025-10-02T23:56:04Z

github-actions · 2025-10-03T03:18:05Z

Test results for "tests 1"

2 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:204 › should not preserve selection across test runs @macos-latest-node18-1
❌ [playwright-test] › reporter-html.spec.ts:2999 › created › execSync doesnt produce a second stdout attachment @macos-latest-node18-2

5 flaky

⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@macos-latest-node18-1`
⚠️ [installation tests] › validate-dependencies.spec.ts:20 › should validate dependencies correctly if skipped during install `@package-installations-ubuntu-latest`

46884 passed, 811 skipped

Merge workflow run.

dgozman · 2025-10-03T08:09:44Z

tests/config/browserTest.ts

-  allowsThirdParty: [async ({ browserName }, run) => {
-    if (browserName === 'firefox' || browserName as any === '_bidiFirefox')
+  allowsThirdParty: [async ({ browserName, channel }, run) => {
+    if (browserName === 'firefox' || channel?.startsWith('moz-firefox'))


Suggested change

if (browserName === 'firefox' || channel?.startsWith('moz-firefox'))

if (browserName === 'firefox')

dgozman · 2025-10-03T08:11:22Z

tests/library/browsercontext-network-event.spec.ts

-it('should not fire events for favicon or favicon redirects', async ({ context, page, server, browserName, headless }) => {
-  it.skip(headless && browserName !== 'firefox' && browserName as any !== '_bidiFirefox', 'headless browsers, except firefox, do not request favicons');
+it('should not fire events for favicon or favicon redirects', async ({ context, page, server, browserName, headless, channel }) => {
+  it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');


Suggested change

it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');

it.skip(headless && browserName !== 'firefox', 'headless browsers, except firefox, do not request favicons');

dgozman · 2025-10-03T08:12:06Z

tests/library/favicon.spec.ts

-it('should load svg favicon with prefer-color-scheme', async ({ page, server, browserName, headless, asset }) => {
-  it.skip(headless && browserName !== 'firefox' && browserName as any !== '_bidiFirefox', 'headless browsers, except firefox, do not request favicons');
+it('should load svg favicon with prefer-color-scheme', async ({ page, server, browserName, headless, asset, channel }) => {
+  it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');


Suggested change

it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');

it.skip(headless && browserName !== 'firefox', 'headless browsers, except firefox, do not request favicons');

dgozman · 2025-10-03T08:12:22Z

tests/library/har.spec.ts

-it('should filter favicon and favicon redirects', async ({ server, browserName, headless, asset, contextFactory }, testInfo) => {
-  it.skip(headless && browserName !== 'firefox' && browserName as any !== '_bidiFirefox', 'headless browsers, except firefox, do not request favicons');
+it('should filter favicon and favicon redirects', async ({ server, browserName, headless, asset, contextFactory, channel }, testInfo) => {
+  it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');


Suggested change

it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');

it.skip(headless && browserName !== 'firefox', 'headless browsers, except firefox, do not request favicons');

dgozman · 2025-10-03T08:12:34Z

tests/library/page-close.spec.ts

  expect((await respPromise).message).toContain(kTargetClosedErrorMessage);
  // All headers are the same as "provisional" headers in Firefox.
-  if (browserName === 'firefox' || browserName as any === '_bidiFirefox')
+  if (browserName === 'firefox' || channel?.startsWith('moz-firefox'))


Suggested change

if (browserName === 'firefox' || channel?.startsWith('moz-firefox'))

if (browserName === 'firefox')

dgozman · 2025-10-03T08:12:48Z

tests/page/page-basic.spec.ts


  // Third part for Firefox is the last one and encodes engine and browser versions.
-  if (browserName === 'firefox' || browserName as any === '_bidiFirefox') {
+  if (browserName === 'firefox' || channel?.startsWith('moz-firefox')) {


Suggested change

if (browserName === 'firefox' || channel?.startsWith('moz-firefox')) {

if (browserName === 'firefox') {

dgozman · 2025-10-03T08:13:26Z

tests/page/page-event-console.spec.ts

-  if (browserName === 'webkit' || browserName as any === '_bidiFirefox')
+  if (browserName === 'webkit' || channel?.startsWith('moz-firefox'))
    expect(text).toEqual('Error: Exception');
  if (browserName === 'firefox')


Suggested change

if (browserName === 'firefox')

else if (browserName === 'firefox')

dgozman · 2025-10-03T08:14:05Z

tests/page/page-route.spec.ts

    if (browserName === 'webkit')
      expect(error.message).toContain('TypeError');
-    if (browserName === 'firefox' || browserName === '_bidiFirefox')
+    if (browserName === 'firefox' || channel?.startsWith('moz-firefox'))


Suggested change

if (browserName === 'firefox' || channel?.startsWith('moz-firefox'))

if (browserName === 'firefox')

yury-s · 2025-10-03T15:25:25Z

I'd prefer to leave redundant channel?.startsWith('moz-firefox') conditions for documentation purposes and in case we want to use different browser name again. We can always clean it up later, but for now it disambiguates wether the behavior is expected in bidi.

chore(bidi): use firefox browser type with moz-firefox- channel

32e928b

yury-s requested review from dgozman and pavelfeldman October 2, 2025 23:16

pavelfeldman approved these changes Oct 2, 2025

View reviewed changes

channel is optional

2b90eda

This comment has been minimized.

Sign in to view

fix tests

54239bf

This comment has been minimized.

Sign in to view

dgozman approved these changes Oct 3, 2025

View reviewed changes

yury-s merged commit c85932f into microsoft:main Oct 3, 2025
33 of 37 checks passed

yury-s deleted the bidi-ff-channel branch October 3, 2025 15:25

This was referenced Oct 3, 2025

[Ports]: Backport client side changes for 1.57 microsoft/playwright-python#2985

Open

[Ports]: Backport client side changes for 1.57 microsoft/playwright-java#1848

Open

[Ports]: Backport client side changes for 1.57 microsoft/playwright-dotnet#3242

Open

yury-s mentioned this pull request Oct 3, 2025

[Feature]: Allow to configure the protocol (juggler or webDriverBiDi) when launching the browser #37277

Open

This was referenced Oct 7, 2025

test(bidi): unskip some Firefox BiDi tests #37751

Merged

test(bidi): update test expectations for Firefox BiDi #37827

Merged

	if (browserName === 'firefox' \|\| channel?.startsWith('moz-firefox'))
	if (browserName === 'firefox')

	it.skip(headless && browserName !== 'firefox' && !channel?.startsWith('moz-firefox'), 'headless browsers, except firefox, do not request favicons');
	it.skip(headless && browserName !== 'firefox', 'headless browsers, except firefox, do not request favicons');

	if (browserName === 'firefox' \|\| channel?.startsWith('moz-firefox')) {
	if (browserName === 'firefox') {

	if (browserName === 'firefox')
	else if (browserName === 'firefox')

chore(bidi): use firefox browser type with moz-firefox- channel #37696

chore(bidi): use firefox browser type with moz-firefox- channel #37696

Uh oh!

Conversation

yury-s commented Oct 2, 2025

Uh oh!

yury-s commented Oct 2, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 3, 2025

Test results for "tests 1"

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yury-s commented Oct 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants