fix(types): update types for test.extend #33784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
- Replace `KeyValue` with `{}` to avoid inferring `KeyValue` when not intended
and turning all properties into `any`.
- Employ `as Exclude<K, keyof PW | keyof PT>` technique to make sure
overridden fixtures inherit from the base test type, and are not looked up
in the extended fixtures list where they are not present.
This should fix errors with TypeScript 5.8.
dgozman
force-pushed
the
ts-update-test-extend-types
branch
from
b27eeb0 to
c1447eb
Compare
Test results for "tests 1"2 flaky37172 passed, 650 skipped Merge workflow run. |
pavelfeldman
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyValuewith{}to avoid inferringKeyValuewhen not intended and turning all properties intoany.Exclude<keyof K, keyof PW | keyof PT>to make sure overridden fixtures inherit from the base test type, and are not looked up in the extended fixtures list where they are not present.This should fix errors with TypeScript 5.8.
Fixes #33763.
See microsoft/TypeScript#60619 and #33782 for more context.