-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Types for fixtures are broken in TypeScript 5.7.2 #33763
Comments
I can repro. Bisecting results: bad 5.7.0-dev.20240820 2192336dfee6f740b5828c8a4a8226e56626de1d RANGE: microsoft/TypeScript@2a8865e...2192336 Also when trying to use |
Thanks for looking into this @mxschmitt. This may be a TypeScript regression/issue, and happy to raise there if you think that's the case. |
We should probably at least create a tracking issue for visibility - since it seems like a regression on their side. Do you mind filing it? Maybe we can workaround it on our side - we'll see. I assigned it to the next release so we'll pick it up. |
I've just raised that here: microsoft/TypeScript#60619 |
The fix is merged to the repo but there is no release. Can we please have a smol release 🙏 |
We recommend Canary in the meantime: https://playwright.dev/docs/canary-releases |
Version
1.49.0
Steps to reproduce
Clone this repro, run
pnpm i
and see the issue in the example test.https://github.com/mrmckeb/pw-repro
Expected behavior
Fixtures should work as they did in TypeScript 5.6.3.
The fixture in this example is copy-pasted from the Playwright docs, but I found this within our project with more complex fixtures in use.
Actual behavior
Fixtures now throw type errors, with values seemingly being
any
.Confusingly, the JSDoc shows up correctly.
Additional context
This may be a TypeScript issue, and I'm happy to re-open there if that's the case.
I did look for related issues earlier and didn't find any.
Environment
The text was updated successfully, but these errors were encountered: