Skip to content

build(build): upgrade to Node 24 and bump npm devDependencies#414

Merged
WilliamBerryiii merged 4 commits into
mainfrom
fix/node24-cspell10
Apr 8, 2026
Merged

build(build): upgrade to Node 24 and bump npm devDependencies#414
WilliamBerryiii merged 4 commits into
mainfrom
fix/node24-cspell10

Conversation

@WilliamBerryiii
Copy link
Copy Markdown
Member

Description

cspell 10.0.0 drops Node 20 support (requires >=22.18.0). This PR upgrades the entire repository to Node 24.14.1 and bumps all four pending devDependency updates.

Closes #413
Supersedes #402

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Infrastructure change
  • Code refactoring

Component(s) Affected

  • Infrastructure / Terraform
  • Training Pipeline
  • Evaluation / SIL
  • Data Management / Viewer
  • Data Pipeline
  • CI/CD / Scripts

Testing Performed

  • npm run spell-check — 544 files, zero issues
  • npm run lint:md — 183 files, zero errors
  • npm run lint:yaml — zero issues
  • npm run test:ps — 1026 tests passed, 0 failed

Documentation Impact

  • No documentation changes needed

Bug Fix Checklist

  • Root cause identified: cspell 10.0.0 engines field requires Node >=22.18.0
  • Fix addresses root cause (not just symptoms): Node pinned to 24.14.1 everywhere
  • Regression test: Pester fixtures updated to validate pinned version

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes

Changes Summary

File Change
.github/actions/setup-node-deps/action.yml Default '20''24.14.1'
.github/workflows/deploy-docs.yml node-version: 20'24.14.1'
.github/workflows/docusaurus-tests.yml '20''24.14.1'
data-management/viewer/frontend/.nvmrc 2224.14.1
data-management/viewer/frontend/Dockerfile node:22-slimnode:24.14.1-slim
docs/docusaurus/package.json engines >=20>=24
package.json engines >=20>=24; cspell 9→10, lint-staged 16.2→16.4, markdown-table-formatter 1.6→1.7, markdownlint-cli2 0.21→0.22
package-lock.json Regenerated
5× Pester fixtures node-version: '20''24.14.1'

- upgrade setup-node-deps composite action default from Node 20 to 24
- pin Node 24.14.1 in .nvmrc and node:24-slim in Dockerfile
- bump cspell 9.4.0 to 10.0.0, lint-staged 16.2.7 to 16.4.0
- bump markdown-table-formatter 1.6.0 to 1.7.0, markdownlint-cli2 0.21.0 to 0.22.0
- update Pester test fixtures from Node 20 to 24

🔧 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner April 8, 2026 02:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 1 packages with OpenSSF Scorecard issues.

View full job summary

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.48%. Comparing base (701ee5d) to head (b047416).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   50.48%   50.48%           
=======================================
  Files         267      267           
  Lines       18188    18188           
  Branches     1855     1903   +48     
=======================================
  Hits         9182     9182           
  Misses       8716     8716           
  Partials      290      290           
Flag Coverage Δ *Carryforward flag
pester 81.21% <ø> (ø)
pytest 6.89% <ø> (ø) Carriedforward from 502c9c5
pytest-dataviewer 61.97% <ø> (ø)
vitest 50.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- regenerate package-lock.json with full platform-specific optional dep entries
- fix npm ci failure caused by missing entries for @unrs/resolver-binding, fsevents, @napi-rs/wasm-runtime, and @emnapi packages
- lockfileVersion 3 now has 19 @unrs/resolver-binding entries (was 2), plus fsevents, @napi-rs, and @emnapi entries (were 0)

🔧 - Generated by Copilot
- add GHSA-c2c7-rcm5-vvqj (ReDoS via extglob quantifiers, CVE-2026-33671)
- add GHSA-3v7f-55p6-f55p (method injection in POSIX char classes, CVE-2026-33672)

🔒 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii merged commit e46ddcd into main Apr 8, 2026
31 checks passed
@WilliamBerryiii WilliamBerryiii deleted the fix/node24-cspell10 branch April 8, 2026 19:33
WilliamBerryiii pushed a commit that referenced this pull request Apr 8, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.6.1](v0.6.0...v0.6.1)
(2026-04-08)


### 📦 Build System

* **build:** upgrade to Node 24 and bump npm devDependencies
([#414](#414))
([e46ddcd](e46ddcd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: physical-ai-toolchain-release[bot] <267194360+physical-ai-toolchain-release[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Node to 24 and bump cspell 10.0.0 (drops Node 20 support)

3 participants