Fix TraceParserGen to generate meaningful parser for WPF #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oatkins
force-pushed
the
fix-trace-parser-gen
branch
from
72116c4 to
df8f9c9
Compare
oatkins
force-pushed
the
fix-trace-parser-gen
branch
from
df8f9c9 to
a727a4d
Compare
|
See also #950 - need to make sure the problems resolved there are not reintroduced here. |
| @@ -276,8 +304,10 @@ private void GenerateTemplateDefs(TextWriter output) | |||
| state = ", state"; | |||
| } | |||
|
|
|||
| output.WriteLine(" return new {0}(action, {1}, {2}, \"{3}\", Guid.Empty, {4}, \"{5}\", ProviderGuid, ProviderName {6});", | |||
| templateClassName, evnt.Id, evnt.Task, TraceParserGen.ToCSharpName(evnt.TaskName), evnt.Opcode, TraceParserGen.ToCSharpName(evnt.OpcodeName), state); | |||
| var taskGuid = string.IsNullOrEmpty(evnt.TaskName) ? "Guid.Empty" : ToCSharpName(evnt.TaskName) + "TaskGuid"; | |||
There was a problem hiding this comment.
Shouldn't it check m_taskGuids?
If there is no "eventGUID" attributes in parsed manifest, I think it should return Guid.Empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve #1351 and supports creating a parser for the Microsoft-Windows-WPF provider from the manifest at C:\Windows\Microsoft.NET\Framework\v4.0.30319\WPF\wpf-etw.man.
See also #554.
Addresses various issues with the generated provider:
RegisterTemplate()seems not to exist;source.RegisterEventTemplateis apparently what was intended.