Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceParserGen: xxxTaskGuid not defined #1351

Open
dorian-apanel-intel opened this issue Jan 27, 2021 · 4 comments · May be fixed by #1406 or #1414
Open

TraceParserGen: xxxTaskGuid not defined #1351

dorian-apanel-intel opened this issue Jan 27, 2021 · 4 comments · May be fixed by #1406 or #1414
Labels
bug

Comments

@dorian-apanel-intel
Copy link
Contributor

I'm trying to compile cs code generated by TraceParserGen with custom manifest.

First problem I see is that guids passed to RegisterTemplate() are not defied.
Then I found this comment in code

// as of today, the generated code won't compile because the task GUID is not defined
// TODO: define the xxxTaskGuid based on eventGUID attribute of <task> elements of the .man file

Is it going to be fixed?
It happens both if I define eventGUID attribute or not.
@brianrob
Copy link
Member

brianrob commented Feb 1, 2021

@dorian-apanel-intel, this can be fixed, but wasn't an issue that I was aware of. Would you be up for submitting a PR for this?

@brianrob brianrob added the bug label Feb 1, 2021
@dorian-apanel-intel
Copy link
Contributor Author

Hi, I fixed it for myself.
I'm going to propose a PR soon.

@oatkins oatkins linked a pull request Apr 6, 2021 that will close this issue
Open
dorian-apanel-intel added a commit to dorian-apanel-intel/perfview that referenced this issue Apr 20, 2021
@dorian-apanel-intel
TraceParserGen: Fix task guids and RegisterTemplate.
656de09 
Add Task class and keep instances in m_tasks dictionary
instead of m_taskNames, m_taskValues and potential m_taskGuids.

Generate guids variables or pass Guid.Empty

Add basic RegisterTemplate implementation.

fix microsoft#1351
@dorian-apanel-intel dorian-apanel-intel linked a pull request Apr 20, 2021 that will close this issue
Open
@Whathecode Whathecode mentioned this issue Feb 7, 2023
Open
@limulidae
Copy link

Is this fixed?

@brianrob
Copy link
Member

I don't believe that this has been fixed. Fixes to TraceParserGen have been held up behind a goal to create a test-bed for the tool first, as each time we take a change, we tend to break something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@brianrob @limulidae @dorian-apanel-intel