Revert Softmax optimizations using openmp. #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracysh
approved these changes
Dec 4, 2018
Contributor
|
What's the reason for reverting? |
Contributor
Author
The perf gain is too small to the transformer model currently after it use dynamic input sequence length. And we do not have enough real data to do the perf tuning based on this change. |
pranavsharma
pushed a commit
that referenced
this pull request
Dec 5, 2018
* Update Dockerfile for ARM build and build description * Update BUILD.md for ARM build * Fix typo * Kezhan/renaming graph_base.h to graph.h (#95) * rename graph.h to graph_viewer.h * rename graph_base.h to graph.h * Implement StringNormalizer (#69) * Imlpement StringNormalizer Add mixed language tests, test case insentive path. * Create a locale on the fly. Default locale does not seem to create well. * Add CI language-pack-en to make default locale available. Catch and translate locale creation exception to make the message meaningful. * Make sure locales are configured on Ubuntu. * Split the CI pipelines (#94) * Add the split build badges (#96) * Split the CI pipelines * Update build bdge display table in README * Revert Softmax optimizations using openmp. (#97) Revert "Simpler unused parameter in #if defined() switch." This reverts commit 6b00e6b. Revert "Better opemmp parallel group count calculation in Softmax parallel running." This reverts commit c530064. Revert "Optimize softmax cpu by parallel using openmp." This reverts commit e7bdfa0. * Delete logo as per marketing requirements (#98) * Update Dockerfile for ARM build and build description * Update BUILD.md for ARM build * Fix typo
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
Jun 2, 2025
* update * update * Fix build error CK_BUFFER_RESOURCE_3RD_DWORD Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> * Add all archs back + gfx950 Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> --------- Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> Co-authored-by: kithumma <kiran.thumma@amd.com>
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
Jul 8, 2025
* update * update * Fix build error CK_BUFFER_RESOURCE_3RD_DWORD Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> * Add all archs back + gfx950 Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> --------- Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> Co-authored-by: kithumma <kiran.thumma@amd.com>
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squash related reverts together:
Revert "Simpler unused parameter in #if defined() switch."
This reverts commit 6b00e6b.
Revert "Better opemmp parallel group count calculation in Softmax parallel running."
This reverts commit c530064.
Revert "Optimize softmax cpu by parallel using openmp."
This reverts commit e7bdfa0.